Merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final-new into lp:ubuntu-filemanager-app
Proposed by
Carlos Jose Mazieri
Status: | Merged |
---|---|
Approved by: | Arto Jalkanen |
Approved revision: | 424 |
Merged at revision: | 424 |
Proposed branch: | lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final-new |
Merge into: | lp:ubuntu-filemanager-app |
Prerequisite: | lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-13-new |
Diff against target: |
12 lines (+1/-1) 1 file modified
src/app/qml/ui/FolderListPage.qml (+1/-1) |
To merge this branch: | bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final-new |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Ubuntu File Manager Developers | Pending | ||
Review via email: mp+262526@code.launchpad.net |
Commit message
It allows the filemager to browse Samba items by entering any valid url starting with "smb://" or "cifs://".
Description of the change
It replaces https:/
It allows the filemager to browse Samba items by entering any valid url starting with "smb://" or "cifs://".
To test: Menu -> GoTo, type smb:// or cifs://
The property "isDir" should be changed in some places to "isBrowsable", the difference is that "isDir" allows remove/copy/cut while "isBrowsable" just means the item is a container and may have sub items.
To post a comment you must log in.
PASSED: Continuous integration, rev:424 91.189. 93.70:8080/ job/ubuntu- filemanager- app-ci/ 499/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2968 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2968/artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/ubuntu- filemanager- app-utopic- amd64-ci/ 215 91.189. 93.70:8080/ job/ubuntu- filemanager- app-vivid- amd64-ci/ 121
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- filemanager- app-ci/ 499/rebuild
http://