Merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-10 into lp:ubuntu-filemanager-app

Proposed by Carlos Jose Mazieri
Status: Merged
Approved by: Arto Jalkanen
Approved revision: 441
Merged at revision: 446
Proposed branch: lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-10
Merge into: lp:ubuntu-filemanager-app
Prerequisite: lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-09
Diff against target: 32 lines (+14/-0)
2 files modified
src/plugin/folderlistmodel/trash/trashlocation.cpp (+13/-0)
src/plugin/folderlistmodel/trash/trashlocation.h (+1/-0)
To merge this branch: bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-10
Reviewer Review Type Date Requested Status
Arto Jalkanen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265209@code.launchpad.net

Commit message

provided TrashLocation::urlBelongsToLocation()

Description of the change

TrashLocation::urlBelongsToLocation() should have been present in the previous MPs.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Arto Jalkanen (ajalkane) wrote :

Same note as in previous MP, hard-coded length of start of trash url would be best be a constant or logic in LocationUrl

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/plugin/folderlistmodel/trash/trashlocation.cpp'
--- src/plugin/folderlistmodel/trash/trashlocation.cpp 2015-03-01 15:32:42 +0000
+++ src/plugin/folderlistmodel/trash/trashlocation.cpp 2015-07-19 15:32:02 +0000
@@ -314,3 +314,16 @@
314 }314 }
315 return new TrashListWorker(trashDir, urlPath, filter);315 return new TrashListWorker(trashDir, urlPath, filter);
316}316}
317
318
319QString TrashLocation::urlBelongsToLocation(const QString &urlPath, int indexOfColonAndSlashe)
320{
321 QString ret;
322#if defined(Q_OS_UNIX)
323 if (urlPath.startsWith(LocationUrl::TrashRootURL.midRef(0,6)))
324 {
325 ret = LocationUrl::TrashRootURL + DirItemInfo::removeExtraSlashes(urlPath, indexOfColonAndSlashe+1);
326 }
327#endif
328 return ret;
329}
317330
=== modified file 'src/plugin/folderlistmodel/trash/trashlocation.h'
--- src/plugin/folderlistmodel/trash/trashlocation.h 2015-03-01 15:32:42 +0000
+++ src/plugin/folderlistmodel/trash/trashlocation.h 2015-07-19 15:32:02 +0000
@@ -49,6 +49,7 @@
49 virtual DirListWorker * newListWorker(const QString &urlPath,49 virtual DirListWorker * newListWorker(const QString &urlPath,
50 QDir::Filter filter,50 QDir::Filter filter,
51 const bool isRecursive);51 const bool isRecursive);
52 virtual QString urlBelongsToLocation(const QString& urlPath, int indexOfColonAndSlashe);
5253
53 /*!54 /*!
54 * \brief getMovePairPaths() Get: original path and destination trash path55 * \brief getMovePairPaths() Get: original path and destination trash path

Subscribers

People subscribed via source and target branches