Merge lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app
Proposed by
Carlos Jose Mazieri
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alan Pope πΊπ§π± π¦ | ||||
Approved revision: | 585 | ||||
Merged at revision: | 584 | ||||
Proposed branch: | lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 | ||||
Merge into: | lp:ubuntu-filemanager-app | ||||
Diff against target: |
94 lines (+21/-10) 3 files modified
src/plugin/folderlistmodel/networklistworker.cpp (+17/-6) src/plugin/folderlistmodel/networklistworker.h (+3/-3) src/plugin/folderlistmodel/networklocation.cpp (+1/-1) |
||||
To merge this branch: | bzr merge lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jenkins Bot | continuous-integration | Approve | |
Alan Pope πΊπ§π± π¦ (community) | Approve | ||
Renato Araujo Oliveira Filho (community) | Approve | ||
Review via email: mp+315772@code.launchpad.net |
Commit message
FIX the netwotk crash when Localtion::m_info is deleted in the main thread
Description of the change
FIX the netwotk crash when Localtion::m_info is deleted in the main thread because it is used in the worker thread, NetworkListWorker creates its own DirItemInfo instance and copies the data from Localtion::m_info to avoid that problem.
Location and descendant classes should be checked further to avoid deleting Localtion::m_info
To post a comment you must log in.
code looks good and works nice.