Merge lp:~canonical-platform-qa/webbrowser-app/webbrowser-app-private_browsing-refactor_tests-qml into lp:~canonical-platform-qa/webbrowser-app/webbrowser-app-private_browsing-refactor_tests
Proposed by
Leo Arias
Status: | Work in progress |
---|---|
Proposed branch: | lp:~canonical-platform-qa/webbrowser-app/webbrowser-app-private_browsing-refactor_tests-qml |
Merge into: | lp:~canonical-platform-qa/webbrowser-app/webbrowser-app-private_browsing-refactor_tests |
Diff against target: |
224 lines (+160/-2) 4 files modified
src/app/webbrowser/Browser.qml (+2/-1) tests/unittests/qml/CMakeLists.txt (+19/-1) tests/unittests/qml/tst_Browser.qml (+87/-0) tests/unittests/qml/tst_QmlTests.cpp (+52/-0) |
To merge this branch: | bzr merge lp:~canonical-platform-qa/webbrowser-app/webbrowser-app-private_browsing-refactor_tests-qml |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Canonical Platform QA Team | Pending | ||
Review via email: mp+258946@code.launchpad.net |
Description of the change
Experimental branch.
Tests are throwing too many warnings, and the last test doesn't work yet. Also I had to import way to many things to get the file under test. Simple tests like this should be easy to write, so maybe the big Browser.qml file needs to be split.
To post a comment you must log in.
QML tests are intended to test standalone QML components. Browser.qml is not a standalone component by any means, it’s the entire app itself. As such, I don’t think it makes sense to try and test in in a QML test.
I do agree that it would be good if we could reduce its size though, by splitting it into more standalone, reusable components (and add QML tests for those). It has been on my backlog for quite a while, but I’ve never quite gotten around to doing it, although I try not to increase its size with new code submissions, at the very least.
Suggestions on how to do that, and contributions very welcome!