Merge lp:~camptocamp/openobject-addons/7.0-improve-webkit-head-readabiliy into lp:openobject-addons/7.0

Proposed by Nicolas Bessi - Camptocamp
Status: Needs review
Proposed branch: lp:~camptocamp/openobject-addons/7.0-improve-webkit-head-readabiliy
Merge into: lp:openobject-addons/7.0
Diff against target: 35 lines (+13/-6)
1 file modified
report_webkit/header_view.xml (+13/-6)
To merge this branch: bzr merge lp:~camptocamp/openobject-addons/7.0-improve-webkit-head-readabiliy
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp (community) code review, no test Approve
OpenERP Core Team Pending
Review via email: mp+151708@code.launchpad.net

Description of the change

Improvement of webkit header view.

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

However, given the current merge policies, I think there is little chance of getting this merged in the current stable branch. You should probably target this to the trunk branch, and add a community addon for this to get the same feature on a 7.0 instance.

review: Approve (code review, no test)

Unmerged revisions

8797. By Nicolas Bessi - Camptocamp

[IMP] webkit header/footer form lisibility

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'report_webkit/header_view.xml'
--- report_webkit/header_view.xml 2012-11-29 22:26:45 +0000
+++ report_webkit/header_view.xml 2013-03-05 09:33:19 +0000
@@ -26,18 +26,25 @@
26 <field name='company_id'/>26 <field name='company_id'/>
27 <field name="orientation"/>27 <field name="orientation"/>
28 <field name="format"/>28 <field name="format"/>
29 </group><group>29 </group>
30 <group>
30 <field name="margin_top"/>31 <field name="margin_top"/>
31 <field name="margin_bottom"/>32 <field name="margin_bottom"/>
32 <field name="margin_left"/>33 <field name="margin_left"/>
33 <field name="margin_right"/>34 <field name="margin_right"/>
34 </group>35 </group>
35 </group>36 </group>
36 <group>37 <notebook>
37 <field name="css"/>38 <page string="CSS Styling" >
38 <field name="html"/>39 <field name="css" colspan="4"/>
39 <field name="footer_html"/>40 </page>
40 </group>41 <page string="Webkit Header Definition" >
42 <field name="html" colspan="4"/>
43 </page>
44 <page string="Webkit Footer Definition" >
45 <field name="footer_html" colspan="4" />
46 </page>
47 </notebook>
41 </form>48 </form>
42 </field>49 </field>
43 </record>50 </record>