Merge lp:~brunonova/ubuntu/quantal/software-properties/lp1075537 into lp:ubuntu/quantal-proposed/software-properties

Proposed by Bruno Nova
Status: Rejected
Rejected by: Brian Murray
Proposed branch: lp:~brunonova/ubuntu/quantal/software-properties/lp1075537
Merge into: lp:ubuntu/quantal-proposed/software-properties
Diff against target: 19 lines (+2/-0)
1 file modified
softwareproperties/gtk/SoftwarePropertiesGtk.py (+2/-0)
To merge this branch: bzr merge lp:~brunonova/ubuntu/quantal/software-properties/lp1075537
Reviewer Review Type Date Requested Status
Brian Murray Disapprove
Review via email: mp+198137@code.launchpad.net

Description of the change

Fix for bug LP: #1075537 (which was fixed in Saucy) "backported" to Quantal.

I tested this quickly in Virtualbox, and it seems to be working (the fix is trivial).

To test it, just run the fixed version of software-properties-gtk, change something in the software sources (the "Revert" button should become enabled), and close.
A dialog allowing the apt cache to be refreshed should appear.

I didn't change the changelogs or anything else in debian/*.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I'm disapproving this due to the pending EOL of Quantal and the scope of impact of the bug.

review: Disapprove

Unmerged revisions

95. By Bruno Nova

Ensure software sources are refreshed after modification (LP: #1075537)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'softwareproperties/gtk/SoftwarePropertiesGtk.py'
--- softwareproperties/gtk/SoftwarePropertiesGtk.py 2013-02-26 17:21:44 +0000
+++ softwareproperties/gtk/SoftwarePropertiesGtk.py 2013-12-06 23:37:25 +0000
@@ -765,6 +765,7 @@
765 """The config was changed and now needs to be saved and reloaded"""765 """The config was changed and now needs to be saved and reloaded"""
766 apt.apt_pkg.init_config()766 apt.apt_pkg.init_config()
767 self.button_revert.set_sensitive(True)767 self.button_revert.set_sensitive(True)
768 self.modified_sourceslist = True
768769
769 def on_keys_modified(self):770 def on_keys_modified(self):
770 """ The apt keys have changed and need to be redisplayed """771 """ The apt keys have changed and need to be redisplayed """
@@ -777,6 +778,7 @@
777 self.show_isv_sources()778 self.show_isv_sources()
778 self.show_cdrom_sources()779 self.show_cdrom_sources()
779 self.button_revert.set_sensitive(True)780 self.button_revert.set_sensitive(True)
781 self.modified_sourceslist = True
780782
781 def on_auth_failed(self):783 def on_auth_failed(self):
782 """ send when the authentication failed """784 """ send when the authentication failed """

Subscribers

People subscribed via source and target branches

to all changes: