Merge lp:~brian-murray/ubuntu/oneiric/apport/tag-oopses-with-driver into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu

Proposed by Brian Murray
Status: Merged
Merged at revision: 1796
Proposed branch: lp:~brian-murray/ubuntu/oneiric/apport/tag-oopses-with-driver
Merge into: lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu
Diff against target: 57 lines (+17/-3)
2 files modified
data/package-hooks/source_linux.py (+9/-3)
debian/changelog (+8/-0)
To merge this branch: bzr merge lp:~brian-murray/ubuntu/oneiric/apport/tag-oopses-with-driver
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+67979@code.launchpad.net

Description of the change

Per https://launchpad.net/ubuntu/+spec/other-kernel-o-bug-handling it was decided to add a tag to kerneloops bug reports identifying the driver in which the Oops occurred. This branch does that.

It also adds the kerneloops package version for troubleshooting issues with the kerneloops package.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Nice one, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/package-hooks/source_linux.py'
--- data/package-hooks/source_linux.py 2011-04-20 17:42:30 +0000
+++ data/package-hooks/source_linux.py 2011-07-14 15:26:33 +0000
@@ -4,6 +4,7 @@
4Contributors:4Contributors:
5Matt Zimmerman <mdz@canonical.com>5Matt Zimmerman <mdz@canonical.com>
6Martin Pitt <martin.pitt@canonical.com>6Martin Pitt <martin.pitt@canonical.com>
7Brian Murray <brian@canonical.com>
78
8This program is free software; you can redistribute it and/or modify it9This program is free software; you can redistribute it and/or modify it
9under the terms of the GNU General Public License as published by the10under the terms of the GNU General Public License as published by the
@@ -64,14 +65,17 @@
6465
65 if ('Failure' in report and report['Failure'] == 'oops'66 if ('Failure' in report and report['Failure'] == 'oops'
66 and 'OopsText' in report and os.path.exists(SUBMIT_SCRIPT)):67 and 'OopsText' in report and os.path.exists(SUBMIT_SCRIPT)):
68 # tag kerneloopses with the version of the kerneloops package
69 attach_related_packages(report, ['kerneloops'])
67 #it's from kerneloops, ask the user whether to submit there as well70 #it's from kerneloops, ask the user whether to submit there as well
68 if ui is not None:71 if ui is not None:
69 summary = report['OopsText']72 summary = report['OopsText']
70 # Some OopsText begin with "--- [ cut here ] ---", so remove it73 # Some OopsText begin with "--- [ cut here ] ---", so remove it
71 summary = re.sub("---.*\n","",summary)74 summary = re.sub("---.*\n", "", summary)
72 first_line = re.match(".*\n", summary)75 first_line = re.match(".*\n", summary)
73 ip = re.search("IP\:.*\n", summary)76 ip = re.search("(R|E)?IP\:.*\n", summary)
74 call_trace = re.search("Call Trace(.*\n){,10}",summary)77 kernel_driver = re.search("(R|E)?IP is at.*\[(.*)\]\n", summary)
78 call_trace = re.search("Call Trace(.*\n){,10}", summary)
75 oops = ''79 oops = ''
76 if first_line:80 if first_line:
77 oops += first_line.group(0)81 oops += first_line.group(0)
@@ -79,6 +83,8 @@
79 oops += ip.group(0)83 oops += ip.group(0)
80 if call_trace:84 if call_trace:
81 oops += call_trace.group(0)85 oops += call_trace.group(0)
86 if kernel_driver:
87 report['Tags'] += 'kernel-driver-%s' % kernel_driver.group(2)
82 if ui.yesno("This report may also be submitted to "88 if ui.yesno("This report may also be submitted to "
83 "http://kerneloops.org/ in order to help collect aggregate "89 "http://kerneloops.org/ in order to help collect aggregate "
84 "information about kernel problems. This aids in identifying "90 "information about kernel problems. This aids in identifying "
8591
=== modified file 'debian/changelog'
--- debian/changelog 2011-07-14 04:30:53 +0000
+++ debian/changelog 2011-07-14 15:26:33 +0000
@@ -1,3 +1,11 @@
1apport (1.21.2-0ubuntu4) oneiric; urgency=low
2
3 * data/package-hooks/source_linux.py:
4 - tag kerneloops reports with the driver the Oops occurred in
5 - include kerneloops package version in kerneloops reports
6
7 -- Brian Murray <brian@ubuntu.com> Thu, 14 Jul 2011 08:19:46 -0700
8
1apport (1.21.2-0ubuntu3) oneiric; urgency=low9apport (1.21.2-0ubuntu3) oneiric; urgency=low
210
3 * data/general-hooks/ubuntu.py: add in casper package version to bugs11 * data/general-hooks/ubuntu.py: add in casper package version to bugs

Subscribers

People subscribed via source and target branches