Merge lp:~brian-murray/apport/check-cdrom into lp:~apport-hackers/apport/trunk

Proposed by Brian Murray
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~brian-murray/apport/check-cdrom
Merge into: lp:~apport-hackers/apport/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
data/general-hooks/generic.py (+1/-0)
To merge this branch: bzr merge lp:~brian-murray/apport/check-cdrom
Reviewer Review Type Date Requested Status
Martin Pitt (community) Disapprove
Review via email: mp+64444@code.launchpad.net

Description of the change

Looking at casper it seems that the root filesytem on Live Media, like a persistent USB stick, is mounted as /cdrom. I've updated generic.py to check /cdrom for low free space before reporting a bug.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

/cdrom is a read-only mount in the live system as well as installed systems, so it'll always be 100% full. I don't think it's interesting at all apport-wise.

On a live system the only interesting mount is /, as this has the combined read-write system partition.

review: Needs Fixing
Revision history for this message
Martin Pitt (pitti) wrote :

Most likely this is not necessary at all, but keeping open for the case that you intended to check for something different.

Revision history for this message
Martin Pitt (pitti) wrote :

No response for four months, and this looks unintended, closing. Please reopen if you still think that there's something wrong here. Thanks!

review: Disapprove

Unmerged revisions

1902. By Brian Murray

check for low space in root filesystem on persistent media

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/general-hooks/generic.py'
--- data/general-hooks/generic.py 2011-06-12 19:07:37 +0000
+++ data/general-hooks/generic.py 2011-06-13 18:53:22 +0000
@@ -22,6 +22,7 @@
22 # check for low space22 # check for low space
23 mounts = {'/': 'system',23 mounts = {'/': 'system',
24 '/var': '/var',24 '/var': '/var',
25 '/cdrom': 'system'
25 }26 }
2627
27 home = os.getenv('HOME')28 home = os.getenv('HOME')

Subscribers

People subscribed via source and target branches