Merge lp:~binli/unity-settings-daemon/dont-scale-out-of-screen into lp:unity-settings-daemon
Proposed by
Bin Li
Status: | Rejected |
---|---|
Rejected by: | Didier Roche-Tolomelli |
Proposed branch: | lp:~binli/unity-settings-daemon/dont-scale-out-of-screen |
Merge into: | lp:unity-settings-daemon |
Diff against target: |
60 lines (+24/-0) 2 files modified
debian/changelog (+6/-0) plugins/xsettings/gsd-xsettings-manager.c (+18/-0) |
To merge this branch: | bzr merge lp:~binli/unity-settings-daemon/dont-scale-out-of-screen |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lars Karlitski (community) | Disapprove | ||
Sebastien Bacher | Pending | ||
PS Jenkins bot | Pending | ||
Unity Settings Daemon Development Team | Pending | ||
Review via email: mp+268881@code.launchpad.net |
Description of the change
/* In some case, after change the window_scale to 2 will make
window outside of screen.
So we puts a floor on normal window size, which are
WINDOW_
If the window_scale is bigger than scale_x or scale_y, we
will reset the window_scale to 1.
For example if window_scale is 2, and screen rect.width is 1920,
we will not scale, cause WINDOW_WIDTH_LIMIT * 2 is 2048,
the screen don't have enough space for the minimized window. */
To post a comment you must log in.
I don't think introducing another concept ("window_scale") to an already complex decision makes sense.
Instead, I propose that we specify a minimum logical resolution that Ubuntu needs and use that here instead. Ubiquity (and other applications) need to take care not to grow beyond that.