Merge lp:~bilalakhtar/update-manager/unity-crash-fix into lp:update-manager
Proposed by
Bilal Akhtar
Status: | Rejected |
---|---|
Rejected by: | Michael Terry |
Proposed branch: | lp:~bilalakhtar/update-manager/unity-crash-fix |
Merge into: | lp:update-manager |
Diff against target: |
12 lines (+1/-1) 1 file modified
UpdateManager/UnitySupport.py (+1/-1) |
To merge this branch: | bzr merge lp:~bilalakhtar/update-manager/unity-crash-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Core Development Team | Pending | ||
Review via email: mp+61066@code.launchpad.net |
Description of the change
Fix the crash in Unity by using the ENABLED property instead of VISIBLE. We may revert this later when bug #759174 is fixed in Unity.
To post a comment you must log in.
Unmerged revisions
- 2109. By Bilal Akhtar
-
Use MENUITEM_
PROP_ENABLED until Unity is fixed to support the Visible property
I guess this would need more discussion before implementation.
I've filed merge request https:/ /code.launchpad .net/~bilalakht ar/unity/ fix-unity- crash-on- hidden- quicklistitem/ +merge/ 61067 which fixes the Unity crash on setting VISIBLE to false.
Now we have 2 choices:
1) Go with the current arrangement, since that Unity branch should land in very soon.
2) Use the ENABLED property to disable/enable the Install All Updates button, even when the Unity bug gets fixed.
Its an ergonomic difference. Michael?