Merge lp:~azzar1/libunity/fix-1506744 into lp:libunity

[Andrea Azzarone]

Process GFileMonitors signals with a small timeout.

Process GFileMonitors signals with a small timeout. Please note that https://bugs.launchpad.net/ubuntu/+source/libunity/+bug/1506744/comments/42 is also required.

[Marco Trevisan (Treviño) (3v1n0)]

Good one, thanks

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:324
http://jenkins.qa.ubuntu.com/job/libunity-ci/143/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libunity-xenial-amd64-ci/1/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libunity-xenial-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libunity-xenial-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/libunity-ci/143/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'src/unity-appinfo-manager.vala'
--- src/unity-appinfo-manager.vala	2014-02-03 17:22:39 +0000
+++ src/unity-appinfo-manager.vala	2016-05-16 23:13:54 +0000
@@ -62,13 +62,15 @@
     private HashTable<string, StringArrayWrapper> categories_by_id; /* desktop id or path -> xdg cats */
     private HashTable<string, StringArrayWrapper> keywords_by_id; /* desktop id or path -> X-GNOME-Keywords and X-AppInstall-Keywords */
     private HashTable<string,string?> paths_by_id; /* desktop id -> full path to desktop file */
-    
+    private List<uint> timeout_handlers;
+
     private AppInfoManager ()
     {
       appinfo_by_id = new HashTable<string,AppInfo?> (str_hash, str_equal);
       categories_by_id = new HashTable<string,StringArrayWrapper> (str_hash, str_equal);
       keywords_by_id = new HashTable<string,StringArrayWrapper> (str_hash, str_equal);
       paths_by_id = new HashTable<string,string?> (str_hash, str_equal);
+      timeout_handlers = new List<uint> ();
 
       monitors = new HashTable<string,FileMonitor> (str_hash, str_equal);
       
@@ -86,7 +88,15 @@
           }
         }
     }
-    
+
+    ~AppInfoManager ()
+    {
+      timeout_handlers.foreach ((id) =>
+        {
+          Source.remove (id);
+        });
+    }
+
     [Deprecated (replacement = "AppInfoManager.get_default")]
     public static AppInfoManager get_instance ()
     {
@@ -114,21 +124,31 @@
      * we remove it from the cache */
     private void on_dir_changed (FileMonitor mon, File file, File? other_file, FileMonitorEvent e)
     {
-      var desktop_id = file.get_basename ();
-      var path = file.get_path ();
-      AppInfo? appinfo;
-      
-      if (appinfo_by_id.remove (desktop_id))
-        {
-          appinfo = lookup (desktop_id);
-          changed (desktop_id, appinfo);
-        }
-      
-      if (appinfo_by_id.remove (path))
-        {
-          appinfo = lookup (path);
-          changed (path, appinfo);
-        }
+      uint timeout_handler = 0;
+
+      timeout_handler = Timeout.add_seconds (2, () =>
+      {
+        var desktop_id = file.get_basename ();
+        var path = file.get_path ();
+        AppInfo? appinfo;
+
+        if (appinfo_by_id.remove (desktop_id))
+          {
+            appinfo = lookup (desktop_id);
+            changed (desktop_id, appinfo);
+          }
+      
+        if (appinfo_by_id.remove (path))
+          {
+            appinfo = lookup (path);
+            changed (path, appinfo);
+          }
+
+        timeout_handlers.remove (timeout_handler);
+        return false;
+      });
+
+      timeout_handlers.append (timeout_handler);
     }
     
     /**