Merge lp:~artmello/webbrowser-app/webbrowser-app-fix_1484555 into lp:webbrowser-app

Proposed by Arthur Mello
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1140
Merged at revision: 1143
Proposed branch: lp:~artmello/webbrowser-app/webbrowser-app-fix_1484555
Merge into: lp:webbrowser-app
Diff against target: 37 lines (+2/-9)
1 file modified
src/app/webbrowser/Browser.qml (+2/-9)
To merge this branch: bzr merge lp:~artmello/webbrowser-app/webbrowser-app-fix_1484555
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Olivier Tilloy Approve
Review via email: mp+268154@code.launchpad.net

Commit message

Make sure to set the historyModel to the HistoryView component when browser wide property changes

Description of the change

Make sure to set the historyModel to the HistoryView component when browser wide property changes

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1139. By Arthur Mello

Simplify the way that the timer is triggered

1140. By Arthur Mello

Merge with trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good to me, thanks.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/webbrowser/Browser.qml'
--- src/app/webbrowser/Browser.qml 2015-08-14 09:25:38 +0000
+++ src/app/webbrowser/Browser.qml 2015-08-16 01:38:10 +0000
@@ -757,6 +757,7 @@
757757
758 onStatusChanged: {758 onStatusChanged: {
759 if (status == Loader.Ready) {759 if (status == Loader.Ready) {
760 historyViewTimer.restart()
760 historyViewLoader.item.forceActiveFocus()761 historyViewLoader.item.forceActiveFocus()
761 } else {762 } else {
762 internal.resetFocus()763 internal.resetFocus()
@@ -766,9 +767,9 @@
766 Keys.onEscapePressed: historyViewLoader.active = false767 Keys.onEscapePressed: historyViewLoader.active = false
767768
768 Timer {769 Timer {
770 id: historyViewTimer
769 // Set the model asynchronously to ensure771 // Set the model asynchronously to ensure
770 // the view is displayed as early as possible.772 // the view is displayed as early as possible.
771 running: historyViewLoader.active
772 interval: 1773 interval: 1
773 onTriggered: historyViewLoader.item.historyModel = browser.historyModel774 onTriggered: historyViewLoader.item.historyModel = browser.historyModel
774 }775 }
@@ -825,14 +826,6 @@
825 internal.resetFocus()826 internal.resetFocus()
826 }827 }
827828
828 Timer {
829 // Set the model asynchronously to ensure
830 // the view is displayed as early as possible.
831 running: true
832 interval: 1
833 onTriggered: historyModel = browser.historyModel
834 }
835
836 onHistoryEntryClicked: {829 onHistoryEntryClicked: {
837 browser.openUrlInNewTab(url, true)830 browser.openUrlInNewTab(url, true)
838 done()831 done()

Subscribers

People subscribed via source and target branches

to status/vote changes: