Merge lp:~andreas-pokorny/mir/move-cookie-test-to-acceptance-tests into lp:mir
Status: | Rejected |
---|---|
Rejected by: | Andreas Pokorny |
Proposed branch: | lp:~andreas-pokorny/mir/move-cookie-test-to-acceptance-tests |
Merge into: | lp:mir |
Diff against target: |
160 lines (+28/-30) 3 files modified
tests/acceptance-tests/CMakeLists.txt (+1/-0) tests/acceptance-tests/test_client_cookie.cpp (+27/-29) tests/umock-acceptance-tests/CMakeLists.txt (+0/-1) |
To merge this branch: | bzr merge lp:~andreas-pokorny/mir/move-cookie-test-to-acceptance-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alan Griffiths | Needs Information | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+275502@code.launchpad.net |
Commit message
Create real cookies from fake input
To detect that new devices reported by udev are valid and have not been removed or stale while being added Libinput
matches device ids through various methods - one of them fstat(device_fd...) is currently not caught by umockdev.
Until that is resolved in umockdev we have to refrain from using that to inject user input.
This change uses fake input devices to do the same - bypassing the evdev platform in this case.
Description of the change
The original test relied on working umockdev - which isnt the case with the libinput platform anymore. So for the time being tests like those need to use the fake input devices.
At some point we might be able to move it back..
Unmerged revisions
- 3050. By Andreas Pokorny
-
Add a todo - when umockdev works again we should add another test that also includes evdev input
- 3049. By Andreas Pokorny
-
Moving Cookie client test to a acceptance test and using fake input devices instead
To detect that new devices reported by udev are valid and have not been removed or stale while being added Libinput
matches device ids through various methods - one of them fstat(device_fd...) is currently not caught by umockdev.
Until that is resolved in umockdev we have to refrain from using that to inject user input.This change uses fake input devices to do the same - bypassing the evdev platform in this case.
PASSED: Continuous integration, rev:3050 jenkins. qa.ubuntu. com/job/ mir-ci/ 5380/ jenkins. qa.ubuntu. com/job/ mir-android- vivid-i386- build/4610 jenkins. qa.ubuntu. com/job/ mir-clang- vivid-amd64- build/3517 jenkins. qa.ubuntu. com/job/ mir-mediumtests -vivid- touch/4552 jenkins. qa.ubuntu. com/job/ mir-mediumtests -wily-touch/ 510/console jenkins. qa.ubuntu. com/job/ mir-wily- amd64-ci/ 1534 jenkins. qa.ubuntu. com/job/ mir-wily- amd64-ci/ 1534/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ mir-wily- i386-ci/ 510 jenkins. qa.ubuntu. com/job/ mir-wily- i386-ci/ 510/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ mir-mediumtests -builder- vivid-armhf/ 4553 jenkins. qa.ubuntu. com/job/ mir-mediumtests -builder- vivid-armhf/ 4553/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ mir-mediumtests -runner- touch/7178 s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 24498 jenkins. qa.ubuntu. com/job/ mir-mediumtests -builder- wily-armhf/ 511/console
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/mir- ci/5380/ rebuild
http://