Merge lp:~allenap/maas/no-requests-for-simplestreams into lp:~maas-committers/maas/trunk
Proposed by
Gavin Panella
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Gavin Panella | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 3997 | ||||
Proposed branch: | lp:~allenap/maas/no-requests-for-simplestreams | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
47 lines (+23/-0) 1 file modified
src/provisioningserver/plugin.py (+23/-0) |
||||
To merge this branch: | bzr merge lp:~allenap/maas/no-requests-for-simplestreams | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Blake Rouse (community) | Approve | ||
Review via email: mp+261235@code.launchpad.net |
Commit message
Experimentally force simplestreams to use `urllib2` instead of `requests`.
The latter appears to be allowing simplestreams to leak file-descriptors; streaming requests that are not explicitly closed remain referenced by a connection pool and thus not garbage-collected.
To post a comment you must log in.
Looks good, but let's get proof that this solves the problem we're seeing before landing this…