Merge ~alfonsosanchezbeato/network-manager:remove-kernel-module-control into network-manager:snap-1.10

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Tony Espy
Approved revision: c7a3fe14e415b7ae3366495e66abe9ee811f2288
Merged at revision: 783e4d70451307df404d5f154101c9d4a6c4fcb1
Proposed branch: ~alfonsosanchezbeato/network-manager:remove-kernel-module-control
Merge into: network-manager:snap-1.10
Diff against target: 13 lines (+1/-1)
1 file modified
snap/snapcraft.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Tony Espy Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+371197@code.launchpad.net

Commit message

snap: remove kernel-module-control interface

The firewall-control interface already provides a kmod plug that makes
sure the modules needed by ip tables are pre-loaded on boot.

Description of the change

snap: remove kernel-module-control interface

The firewall-control interface already provides a kmod plug that makes
sure the modules needed by ip tables are pre-loaded on boot.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tony Espy (awe) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index fd1b42a..b43ac42 100644
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -50,7 +50,7 @@ apps:
50 command: bin/networkmanager50 command: bin/networkmanager
51 daemon: simple51 daemon: simple
52 slots: [service]52 slots: [service]
53 plugs: [modem-manager, ppp, network-setup-observe, wpa, firewall-control, hardware-observe, kernel-module-control]53 plugs: [modem-manager, ppp, network-setup-observe, wpa, firewall-control, hardware-observe]
5454
55layout:55layout:
56 /usr/lib/x86_64-linux-gnu/xtables:56 /usr/lib/x86_64-linux-gnu/xtables:

Subscribers

People subscribed via source and target branches