Mir

Merge lp:~alan-griffiths/mir/test-ABI-bump-libmirserver into lp:mir

Proposed by Alan Griffiths
Status: Rejected
Rejected by: Alan Griffiths
Proposed branch: lp:~alan-griffiths/mir/test-ABI-bump-libmirserver
Merge into: lp:mir
Diff against target: 167 lines (+8/-37)
5 files modified
CMakeLists.txt (+1/-1)
debian/control (+2/-2)
debian/libmirserver30.install (+1/-1)
src/server/CMakeLists.txt (+1/-1)
src/server/symbols.map (+3/-32)
To merge this branch: bzr merge lp:~alan-griffiths/mir/test-ABI-bump-libmirserver
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Alan Griffiths Disapprove
Review via email: mp+250177@code.launchpad.net

Commit message

*Test MP*

It looks as though bumping the mir server ABI breaks the maki when installed. This is just that change to see what happens.

Description of the change

*Test MP*

It looks as though bumping the mir server ABI breaks the maki when installed. This is just that change to see what happens.

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Not intended to land

review: Disapprove
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Unmerged revisions

2328. By Alan Griffiths

Just the libmirserver ABI bump

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-02-13 06:12:34 +0000
+++ CMakeLists.txt 2015-02-18 17:42:16 +0000
@@ -27,7 +27,7 @@
27set(LIBRARY_OUTPUT_PATH ${CMAKE_BINARY_DIR}/lib)27set(LIBRARY_OUTPUT_PATH ${CMAKE_BINARY_DIR}/lib)
2828
29set(MIR_VERSION_MAJOR 0)29set(MIR_VERSION_MAJOR 0)
30set(MIR_VERSION_MINOR 12) # This should change at least with every MIRSERVER_ABI30set(MIR_VERSION_MINOR 13) # This should change at least with every MIRSERVER_ABI
31set(MIR_VERSION_PATCH 0)31set(MIR_VERSION_PATCH 0)
3232
33add_definitions(-DMIR_VERSION_MAJOR=${MIR_VERSION_MAJOR})33add_definitions(-DMIR_VERSION_MAJOR=${MIR_VERSION_MAJOR})
3434
=== modified file 'debian/control'
--- debian/control 2015-02-18 03:04:18 +0000
+++ debian/control 2015-02-18 17:42:16 +0000
@@ -61,7 +61,7 @@
6161
62#TODO: Packaging infrastructure for better dependency generation,62#TODO: Packaging infrastructure for better dependency generation,
63# ala pkg-xorg's xviddriver:Provides and ABI detection.63# ala pkg-xorg's xviddriver:Provides and ABI detection.
64Package: libmirserver2964Package: libmirserver30
65Section: libs65Section: libs
66Architecture: i386 amd64 armhf arm6466Architecture: i386 amd64 armhf arm64
67Multi-Arch: same67Multi-Arch: same
@@ -127,7 +127,7 @@
127Architecture: i386 amd64 armhf arm64127Architecture: i386 amd64 armhf arm64
128Multi-Arch: same128Multi-Arch: same
129Pre-Depends: ${misc:Pre-Depends}129Pre-Depends: ${misc:Pre-Depends}
130Depends: libmirserver29 (= ${binary:Version}),130Depends: libmirserver30 (= ${binary:Version}),
131 libmirplatform-dev (= ${binary:Version}),131 libmirplatform-dev (= ${binary:Version}),
132 libmircommon-dev (= ${binary:Version}),132 libmircommon-dev (= ${binary:Version}),
133 libglm-dev,133 libglm-dev,
134134
=== renamed file 'debian/libmirserver29.install' => 'debian/libmirserver30.install'
--- debian/libmirserver29.install 2015-01-21 09:03:53 +0000
+++ debian/libmirserver30.install 2015-02-18 17:42:16 +0000
@@ -1,1 +1,1 @@
1usr/lib/*/libmirserver.so.291usr/lib/*/libmirserver.so.30
22
=== modified file 'src/server/CMakeLists.txt'
--- src/server/CMakeLists.txt 2015-02-13 06:12:34 +0000
+++ src/server/CMakeLists.txt 2015-02-18 17:42:16 +0000
@@ -106,7 +106,7 @@
106 ${CMAKE_SOURCE_DIR}/include/server/mir DESTINATION "include/mirserver"106 ${CMAKE_SOURCE_DIR}/include/server/mir DESTINATION "include/mirserver"
107)107)
108108
109set(MIRSERVER_ABI 29) # Be sure to increment MIR_VERSION_MINOR at the same time109set(MIRSERVER_ABI 30) # Be sure to increment MIR_VERSION_MINOR at the same time
110set(symbol_map ${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)110set(symbol_map ${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
111111
112set_target_properties(112set_target_properties(
113113
=== modified file 'src/server/symbols.map'
--- src/server/symbols.map 2015-02-13 06:12:34 +0000
+++ src/server/symbols.map 2015-02-18 17:42:16 +0000
@@ -1,4 +1,4 @@
1MIR_SERVER_29 {1MIR_SERVER_30 {
2 global:2 global:
3 extern "C++" {3 extern "C++" {
4# Symbols not yet picked up by script4# Symbols not yet picked up by script
@@ -213,6 +213,7 @@
213 mir::scene::SurfaceBufferAccess::?SurfaceBufferAccess*;213 mir::scene::SurfaceBufferAccess::?SurfaceBufferAccess*;
214 mir::scene::SurfaceBufferAccess::SurfaceBufferAccess*;214 mir::scene::SurfaceBufferAccess::SurfaceBufferAccess*;
215 mir::scene::SurfaceBufferAccess::with_most_recent_buffer_do*;215 mir::scene::SurfaceBufferAccess::with_most_recent_buffer_do*;
216 mir::scene::Surface::buffers_ready_for_compositor*;
216 mir::scene::Surface::client_size*;217 mir::scene::Surface::client_size*;
217 mir::scene::Surface::compositor_snapshot*;218 mir::scene::Surface::compositor_snapshot*;
218 mir::scene::SurfaceConfigurator::attribute_set*;219 mir::scene::SurfaceConfigurator::attribute_set*;
@@ -225,6 +226,7 @@
225 mir::scene::SurfaceCoordinator::operator*;226 mir::scene::SurfaceCoordinator::operator*;
226 mir::scene::SurfaceCoordinator::raise*;227 mir::scene::SurfaceCoordinator::raise*;
227 mir::scene::SurfaceCoordinator::remove_surface*;228 mir::scene::SurfaceCoordinator::remove_surface*;
229 mir::scene::SurfaceCoordinator::surface_at*;
228 mir::scene::SurfaceCoordinator::?SurfaceCoordinator*;230 mir::scene::SurfaceCoordinator::?SurfaceCoordinator*;
229 mir::scene::SurfaceCoordinator::SurfaceCoordinator*;231 mir::scene::SurfaceCoordinator::SurfaceCoordinator*;
230 mir::scene::SurfaceCreationParameters::of_buffer_usage*;232 mir::scene::SurfaceCreationParameters::of_buffer_usage*;
@@ -377,9 +379,6 @@
377 mir::shell::FocusController::focussed_application*;379 mir::shell::FocusController::focussed_application*;
378 mir::shell::FocusController::operator*;380 mir::shell::FocusController::operator*;
379 mir::shell::FocusController::set_focus_to*;381 mir::shell::FocusController::set_focus_to*;
380 mir::shell::FocusSetter::FocusSetter*;
381 mir::shell::FocusSetter::operator*;
382 mir::shell::FocusSetter::set_focus_to*;
383 mir::shell::HostLifecycleEventListener::?HostLifecycleEventListener*;382 mir::shell::HostLifecycleEventListener::?HostLifecycleEventListener*;
384 mir::shell::HostLifecycleEventListener::HostLifecycleEventListener*;383 mir::shell::HostLifecycleEventListener::HostLifecycleEventListener*;
385 mir::shell::HostLifecycleEventListener::lifecycle_event_occurred*;384 mir::shell::HostLifecycleEventListener::lifecycle_event_occurred*;
@@ -389,16 +388,6 @@
389 mir::shell::InputTargeter::?InputTargeter*;388 mir::shell::InputTargeter::?InputTargeter*;
390 mir::shell::InputTargeter::InputTargeter*;389 mir::shell::InputTargeter::InputTargeter*;
391 mir::shell::InputTargeter::operator*;390 mir::shell::InputTargeter::operator*;
392 mir::shell::SessionCoordinatorWrapper::add_prompt_provider_for*;
393 mir::shell::SessionCoordinatorWrapper::close_session*;
394 mir::shell::SessionCoordinatorWrapper::focus_next*;
395 mir::shell::SessionCoordinatorWrapper::focussed_application*;
396 mir::shell::SessionCoordinatorWrapper::handle_surface_created*;
397 mir::shell::SessionCoordinatorWrapper::open_session*;
398 mir::shell::SessionCoordinatorWrapper::SessionCoordinatorWrapper*;
399 mir::shell::SessionCoordinatorWrapper::set_focus_to*;
400 mir::shell::SessionCoordinatorWrapper::start_prompt_session_for*;
401 mir::shell::SessionCoordinatorWrapper::stop_prompt_session*;
402 mir::shell::Shell::add_prompt_provider_for*;391 mir::shell::Shell::add_prompt_provider_for*;
403 mir::shell::Shell::close_session*;392 mir::shell::Shell::close_session*;
404 mir::shell::Shell::create_surface*;393 mir::shell::Shell::create_surface*;
@@ -423,10 +412,6 @@
423 mir::shell::ShellWrapper::ShellWrapper*;412 mir::shell::ShellWrapper::ShellWrapper*;
424 mir::shell::ShellWrapper::start_prompt_session_for*;413 mir::shell::ShellWrapper::start_prompt_session_for*;
425 mir::shell::ShellWrapper::stop_prompt_session*;414 mir::shell::ShellWrapper::stop_prompt_session*;
426 mir::shell::SurfaceCoordinatorWrapper::add_surface*;
427 mir::shell::SurfaceCoordinatorWrapper::raise*;
428 mir::shell::SurfaceCoordinatorWrapper::remove_surface*;
429 mir::shell::SurfaceCoordinatorWrapper::SurfaceCoordinatorWrapper*;
430 mir::terminate_with_current_exception*;415 mir::terminate_with_current_exception*;
431 mir::time::Alarm::?Alarm*;416 mir::time::Alarm::?Alarm*;
432 mir::time::Alarm::Alarm*;417 mir::time::Alarm::Alarm*;
@@ -497,11 +482,6 @@
497 non-virtual?thunk?to?mir::shell::FocusController::?FocusController*;482 non-virtual?thunk?to?mir::shell::FocusController::?FocusController*;
498 non-virtual?thunk?to?mir::shell::HostLifecycleEventListener::?HostLifecycleEventListener*;483 non-virtual?thunk?to?mir::shell::HostLifecycleEventListener::?HostLifecycleEventListener*;
499 non-virtual?thunk?to?mir::shell::InputTargeter::?InputTargeter*;484 non-virtual?thunk?to?mir::shell::InputTargeter::?InputTargeter*;
500 non-virtual?thunk?to?mir::shell::SessionCoordinatorWrapper::close_session*;
501 non-virtual?thunk?to?mir::shell::SessionCoordinatorWrapper::focus_next*;
502 non-virtual?thunk?to?mir::shell::SessionCoordinatorWrapper::focussed_application*;
503 non-virtual?thunk?to?mir::shell::SessionCoordinatorWrapper::open_session*;
504 non-virtual?thunk?to?mir::shell::SessionCoordinatorWrapper::set_focus_to*;
505 non-virtual?thunk?to?mir::shell::ShellWrapper::add_prompt_provider_for*;485 non-virtual?thunk?to?mir::shell::ShellWrapper::add_prompt_provider_for*;
506 non-virtual?thunk?to?mir::shell::ShellWrapper::close_session*;486 non-virtual?thunk?to?mir::shell::ShellWrapper::close_session*;
507 non-virtual?thunk?to?mir::shell::ShellWrapper::create_surface*;487 non-virtual?thunk?to?mir::shell::ShellWrapper::create_surface*;
@@ -515,9 +495,6 @@
515 non-virtual?thunk?to?mir::shell::ShellWrapper::set_surface_attribute*;495 non-virtual?thunk?to?mir::shell::ShellWrapper::set_surface_attribute*;
516 non-virtual?thunk?to?mir::shell::ShellWrapper::start_prompt_session_for*;496 non-virtual?thunk?to?mir::shell::ShellWrapper::start_prompt_session_for*;
517 non-virtual?thunk?to?mir::shell::ShellWrapper::stop_prompt_session*;497 non-virtual?thunk?to?mir::shell::ShellWrapper::stop_prompt_session*;
518 non-virtual?thunk?to?mir::shell::SurfaceCoordinatorWrapper::add_surface*;
519 non-virtual?thunk?to?mir::shell::SurfaceCoordinatorWrapper::raise*;
520 non-virtual?thunk?to?mir::shell::SurfaceCoordinatorWrapper::remove_surface*;
521 non-virtual?thunk?to?mir::time::Alarm::?Alarm*;498 non-virtual?thunk?to?mir::time::Alarm::?Alarm*;
522 non-virtual?thunk?to?mir::time::Timer::?Timer*;499 non-virtual?thunk?to?mir::time::Timer::?Timer*;
523 typeinfo?for?mir::compositor::Compositor;500 typeinfo?for?mir::compositor::Compositor;
@@ -566,13 +543,10 @@
566 typeinfo?for?mir::shell::AbstractShell;543 typeinfo?for?mir::shell::AbstractShell;
567 typeinfo?for?mir::shell::DisplayLayout;544 typeinfo?for?mir::shell::DisplayLayout;
568 typeinfo?for?mir::shell::FocusController;545 typeinfo?for?mir::shell::FocusController;
569 typeinfo?for?mir::shell::FocusSetter;
570 typeinfo?for?mir::shell::HostLifecycleEventListener;546 typeinfo?for?mir::shell::HostLifecycleEventListener;
571 typeinfo?for?mir::shell::InputTargeter;547 typeinfo?for?mir::shell::InputTargeter;
572 typeinfo?for?mir::shell::SessionCoordinatorWrapper;
573 typeinfo?for?mir::shell::Shell;548 typeinfo?for?mir::shell::Shell;
574 typeinfo?for?mir::shell::ShellWrapper;549 typeinfo?for?mir::shell::ShellWrapper;
575 typeinfo?for?mir::shell::SurfaceCoordinatorWrapper;
576 typeinfo?for?mir::time::Alarm;550 typeinfo?for?mir::time::Alarm;
577 typeinfo?for?mir::time::Timer;551 typeinfo?for?mir::time::Timer;
578 vtable?for?mir::compositor::Compositor;552 vtable?for?mir::compositor::Compositor;
@@ -621,13 +595,10 @@
621 vtable?for?mir::shell::AbstractShell;595 vtable?for?mir::shell::AbstractShell;
622 vtable?for?mir::shell::DisplayLayout;596 vtable?for?mir::shell::DisplayLayout;
623 vtable?for?mir::shell::FocusController;597 vtable?for?mir::shell::FocusController;
624 vtable?for?mir::shell::FocusSetter;
625 vtable?for?mir::shell::HostLifecycleEventListener;598 vtable?for?mir::shell::HostLifecycleEventListener;
626 vtable?for?mir::shell::InputTargeter;599 vtable?for?mir::shell::InputTargeter;
627 vtable?for?mir::shell::SessionCoordinatorWrapper;
628 vtable?for?mir::shell::Shell;600 vtable?for?mir::shell::Shell;
629 vtable?for?mir::shell::ShellWrapper;601 vtable?for?mir::shell::ShellWrapper;
630 vtable?for?mir::shell::SurfaceCoordinatorWrapper;
631 vtable?for?mir::time::Alarm;602 vtable?for?mir::time::Alarm;
632 vtable?for?mir::time::Timer;603 vtable?for?mir::time::Timer;
633604

Subscribers

People subscribed via source and target branches