Mir

Merge lp:~alan-griffiths/mir/fix-1722147 into lp:mir

Proposed by Alan Griffiths
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 4291
Proposed branch: lp:~alan-griffiths/mir/fix-1722147
Merge into: lp:mir
Diff against target: 30 lines (+3/-3)
1 file modified
src/platforms/mesa/server/kms/display_buffer.cpp (+3/-3)
To merge this branch: bzr merge lp:~alan-griffiths/mir/fix-1722147
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
Mir CI Bot continuous-integration Approve
Review via email: mp+332270@code.launchpad.net

Commit message

Fix another header for (LP: #1722147)

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:4289
https://mir-jenkins.ubuntu.com/job/mir-ci/3727/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/5120
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/5358
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/5345
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/5345
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/5345
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/5164
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/5164/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/5164
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/5164/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/5164
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/5164/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/5164
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/5164/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/5164
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/5164/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/5164
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/5164/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/5164
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/5164/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/5164
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/5164/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3727/rebuild

review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Seems happy

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/platforms/mesa/server/kms/display_buffer.cpp'
--- src/platforms/mesa/server/kms/display_buffer.cpp 2017-07-28 17:00:43 +0000
+++ src/platforms/mesa/server/kms/display_buffer.cpp 2017-10-14 01:05:56 +0000
@@ -32,7 +32,7 @@
32#include <EGL/eglext.h>32#include <EGL/eglext.h>
33#include MIR_SERVER_GL_H33#include MIR_SERVER_GL_H
34#include <GLES2/gl2ext.h>34#include <GLES2/gl2ext.h>
35#include <drm/drm_fourcc.h>35#include <drm_fourcc.h>
3636
37#include <sstream>37#include <sstream>
38#include <stdexcept>38#include <stdexcept>
@@ -504,7 +504,7 @@
504 make_current();504 make_current();
505505
506 listener->report_successful_egl_make_current_on_construction();506 listener->report_successful_egl_make_current_on_construction();
507 507
508 glClear(GL_COLOR_BUFFER_BIT);508 glClear(GL_COLOR_BUFFER_BIT);
509509
510 surface.swap_buffers();510 surface.swap_buffers();
@@ -776,7 +776,7 @@
776776
777 visible_bypass_frame = scheduled_bypass_frame;777 visible_bypass_frame = scheduled_bypass_frame;
778 scheduled_bypass_frame = nullptr;778 scheduled_bypass_frame = nullptr;
779 779
780 visible_composite_frame = std::move(scheduled_composite_frame);780 visible_composite_frame = std::move(scheduled_composite_frame);
781 scheduled_composite_frame = nullptr;781 scheduled_composite_frame = nullptr;
782 }782 }

Subscribers

People subscribed via source and target branches