Merge lp:~aisrael/charms/precise/nfs/automated-test-fixes into lp:charms/nfs

Proposed by Adam Israel
Status: Merged
Merged at revision: 18
Proposed branch: lp:~aisrael/charms/precise/nfs/automated-test-fixes
Merge into: lp:charms/nfs
Diff against target: 12 lines (+3/-3)
1 file modified
tests/00-setup (+3/-3)
To merge this branch: bzr merge lp:~aisrael/charms/precise/nfs/automated-test-fixes
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review Queue (community) automated testing Needs Fixing
Review via email: mp+237590@code.launchpad.net

Description of the change

Automated tests don't run in the same privileged context that charm's are installed under, so unit tests need to use sudo for operations like apt.

This MP adds sudo to the test setup, as well as adding -y so automated doesn't hang waiting on user input.

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-1264-results

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10354-results

review: Needs Fixing (automated testing)
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/00-setup'
--- tests/00-setup 2014-02-05 19:24:47 +0000
+++ tests/00-setup 2014-10-08 13:14:16 +0000
@@ -1,5 +1,5 @@
1#!/bin/bash1#!/bin/bash
22
3add-apt-repository ppa:juju/stable3sudo add-apt-repository -y ppa:juju/stable
4apt-get update4sudo apt-get update
5apt-get install amulet python35sudo apt-get -y install amulet python3

Subscribers

People subscribed via source and target branches