Merge lp:~agilebg/account-invoicing/adding_account_fiscal_position_country_7 into lp:~account-core-editors/account-invoicing/7.0

[Alex Comba - Agile BG]

This branch adds the account_fiscal_position_country porting to 7.0

Module description:

A rule to select automatically the fiscal position based on the country.
In the configuration of the country, choose a default fiscal position for it.
When selecting a partner in an invoice, if the fiscal position for the partner is not set, the one from the country will be used.

[Lorenzo Battistini (elbati)]

line 189: too long

review: Needs Fixing

[lp:~agilebg/account-invoicing/adding_account_fiscal_position_country_7]

23. By Alex Comba - Agile BG on 2013-08-28

[FIX] PEP8 style

[Alex Comba - Agile BG (tafaru)]

Lorenzo, now it should be ok.

[Lorenzo Battistini (elbati)]

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Seems redundant with account_fiscal_position_rule in the https://code.launchpad.net/openerp-fiscal-rules project.
Do you have a reason for not reusing it?

review: Needs Information

[Lorenzo Battistini (elbati)]

Guewen, you are right. The functionality seems to be already covered by account_fiscal_position_rule*
I'm closing this MP

review: Disapprove

[Lorenzo Battistini (elbati)]

"I'm closing this MP"

I can't :-)

You can reject this MP.

Thanks

Unmerged revisions

23. By Alex Comba - Agile BG on 2013-08-28

[FIX] PEP8 style

22. By Alex Comba - Agile BG on 2013-08-28

[FIX] avoid country_ids and adjust onchange_partner_id

21. By Alex Comba - Agile BG on 2013-08-27

[IMP] class name

20. By Alex Comba - Agile BG on 2013-08-27

[REF] ported module account_fiscal_position_country to ver. 7.0

19. By Alex Comba - Agile BG on 2013-08-27

[ADD] module account_fiscal_position_country ver. 6.1

=== added directory 'account_fiscal_position_country'
=== added file 'account_fiscal_position_country/__init__.py'
--- account_fiscal_position_country/__init__.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_country/__init__.py	2013-08-28 16:12:06 +0000
@@ -0,0 +1,25 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    Copyright (C) 2011-2013 Agile Business Group sagl
+#	 (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import country
+import account
+import invoice
 
=== added file 'account_fiscal_position_country/__openerp__.py'
--- account_fiscal_position_country/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_country/__openerp__.py	2013-08-28 16:12:06 +0000
@@ -0,0 +1,47 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    Copyright (C) 2011-2013 Agile Business Group sagl
+#    (<http://www.agilebg.com>)
+#    @author Leonardo Pistone <[e-mail]>
+#    Ported to OpenERP 7.0 by Alex Comba <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Fiscal Position by country',
+    'version': '0.3',
+    'category': 'Generic Modules/Accounting',
+    'description': """
+A rule to select automatically the fiscal position based on the country
+In the configuration of the country, choose a default fiscal position for it.
+When selecting a partner in an invoice, if the fiscal position for the partner
+is not set, the one from the country will be used.
+    """,
+    'author': 'Agile Business Group',
+    'website': 'http://www.agilebg.com',
+    'license': 'AGPL-3',
+    'depends': [
+        'base',
+        'account',
+    ],
+    'data': [
+        'country_view.xml',
+    ],
+    "active": False,
+    'installable': True,
+}
 
=== added file 'account_fiscal_position_country/country.py'
--- account_fiscal_position_country/country.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_country/country.py	2013-08-28 16:12:06 +0000
@@ -0,0 +1,39 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    Copyright (C) 2011-2013 Agile Business Group sagl
+#    (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import fields, orm
+
+
+class res_country(orm.Model):
+    _inherit = 'res.country'
+    _columns = {
+        'property_account_position': fields.property(
+            'account.fiscal.position',
+            type='many2one',
+            relation='account.fiscal.position',
+            string="Default Fiscal Position",
+            method=True,
+            view_load=True,
+            help="""The fiscal position will determine taxes and the accounts
+            used for the country, if not set specifically elsewere.""",
+        ),
+    }
 
=== added file 'account_fiscal_position_country/country_view.xml'
--- account_fiscal_position_country/country_view.xml	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_country/country_view.xml	2013-08-28 16:12:06 +0000
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+	<data>
+
+		<record model="ir.ui.view" id="view_country_fiscal_position_form">
+			<field name="name">country.fiscal.position.form</field>
+			<field name="model">res.country</field>
+			<field name="inherit_id" ref="base.view_country_form"/>
+			<field name="arch" type="xml">
+				<field name="code" position="after">
+					<field name="property_account_position" widget="selection"/>
+				</field>
+			</field>
+		</record>
+
+	</data>
+</openerp>
 
=== added file 'account_fiscal_position_country/invoice.py'
--- account_fiscal_position_country/invoice.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_country/invoice.py	2013-08-28 16:12:06 +0000
@@ -0,0 +1,50 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    Copyright (C) 2011-2013 Agile Business Group sagl
+#    (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import fields, orm
+
+
+class account_invoice(orm.Model):
+    _inherit = "account.invoice"
+
+    def onchange_partner_id(
+        self, cr, uid, ids, type, partner_id,
+        date_invoice=False, payment_term=False,
+        partner_bank_id=False, company_id=False
+    ):
+
+        result = super(account_invoice, self).onchange_partner_id(
+            cr, uid, ids, type, partner_id,
+            date_invoice, payment_term, partner_bank_id, company_id)
+
+        if not result['value']['fiscal_position']:
+            if partner_id:
+                partner = self.pool.get('res.partner').browse(
+                    cr, uid, partner_id)
+                result['value']['fiscal_position'] = (
+                    partner.country_id
+                    and partner.country_id.property_account_position
+                    and partner.country_id.property_account_position.id
+                    or False
+                )
+
+        return result