Merge lp:~adeuring/launchpadlib/wadl_info_hwdrivername into lp:~launchpad-pqm/launchpadlib/devel

[Abel Deuring]

[Abel Deuring (adeuring)]

This branch updates wadl-to-refhtml.xsl for the new classes IHWDriverName and IHWDriverPackageName

[Graham Binns (gmb)]

> === modified file 'src/launchpadlib/wadl-to-refhtml.xsl'
> --- src/launchpadlib/wadl-to-refhtml.xsl 2009-01-18 21:16:29 +0000
> +++ src/launchpadlib/wadl-to-refhtml.xsl 2009-06-09 14:17:50 +0000
> @@ -279,6 +279,14 @@
> <xsl:text>/+hwdb/+hwvendorid/</xsl:text>
> <var>&lt;id&gt;</var>
> </xsl:when>
> + <xsl:when test="@id = 'h_w_driver_name'">
> + <xsl:text>/+hwdb/+drivername/</xsl:text>
> + <var>&lt;name&gt;</var>
> + </xsl:when>
> + <xsl:when test="@id = 'h_w_driver_package_name'">
> + <xsl:text>/+hwdb/+driverpackagename/</xsl:text>
> + <var>&lt;package_name&gt;</var>
> + </xsl:when>

I really don't like the fact that there are no tests for these changes
save for watching the output of make build. Please file a bug (on lplib,
I think) about the fact that it would be nice to have a way to test
these.

 review approve
 status approved

review: Approve

[Francis J. Lacoste (flacoste)]

On Tuesday 09 June 2009, Graham Binns wrote:
> Review: Approve
>

The merging of that branch was bounced because of an unrelated failure.

Please don't submit it for merging again. It wouldn't be used by Launchpad to
generate the WADL anyway because launchpadlib is now packaged through buildout
and doesn't use the sourcecode branch anymore.

I need to sort out this problem. I'll make sure to merge that changes in once
it's dealt with.

Sorry for the trouble.

--
Francis J. Lacoste
<email address hidden>

[Robert Collins (lifeless)]

Francis, is this now done-or-irrelevant?

review: Needs Information

Unmerged revisions

42. By Abel Deuring on 2009-06-09

Entries for IHWDriverName and IHWDriverPackageName added to wadl-to-refhtml.xsl

=== modified file 'src/launchpadlib/wadl-to-refhtml.xsl'
--- src/launchpadlib/wadl-to-refhtml.xsl	2009-01-18 21:16:29 +0000
+++ src/launchpadlib/wadl-to-refhtml.xsl	2009-06-09 14:17:50 +0000
@@ -279,6 +279,14 @@
                 <xsl:text>/+hwdb/+hwvendorid/</xsl:text>
                 <var>&lt;id&gt;</var>
             </xsl:when>
+            <xsl:when test="@id = 'h_w_driver_name'">
+                <xsl:text>/+hwdb/+drivername/</xsl:text>
+                <var>&lt;name&gt;</var>
+            </xsl:when>
+            <xsl:when test="@id = 'h_w_driver_package_name'">
+                <xsl:text>/+hwdb/+driverpackagename/</xsl:text>
+                <var>&lt;package_name&gt;</var>
+            </xsl:when>
             <xsl:when test="@id = 'jabber_id'">
                 <xsl:text>/</xsl:text>
                 <var>&lt;person.name&gt;</var>