Merge lp:~adeuring/launchpad/bug-598484 into lp:launchpad

Proposed by Abel Deuring
Status: Merged
Approved by: Deryck Hodge
Approved revision: no longer in the source branch.
Merged at revision: 11064
Proposed branch: lp:~adeuring/launchpad/bug-598484
Merge into: lp:launchpad
Diff against target: 34 lines (+14/-0)
2 files modified
lib/lp/bugs/browser/configure.zcml (+6/-0)
lib/lp/bugs/stories/bugs/xx-bug-text-pages.txt (+8/-0)
To merge this branch: bzr merge lp:~adeuring/launchpad/bug-598484
Reviewer Review Type Date Requested Status
Deryck Hodge (community) code Approve
Review via email: mp+28505@code.launchpad.net

Description of the change

This branch fixes bug 598484 which I caused in my branch for bug 583385. I simply forgot that IHasBugs was not only implemented by IBugTarget and IPerson, but also by IProjectGroup.

So I added another ZCML directive that defines the currently missing page again for project groups.

test: ./bin/test -t xx-bug-text-pages.txt

no lint

To post a comment you must log in.
Revision history for this message
Deryck Hodge (deryck) wrote :

Thanks for making this change so quickly, Abel. Looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/bugs/browser/configure.zcml'
--- lib/lp/bugs/browser/configure.zcml 2010-06-18 10:41:48 +0000
+++ lib/lp/bugs/browser/configure.zcml 2010-06-25 13:44:30 +0000
@@ -59,6 +59,12 @@
59 name="+bugs-text"59 name="+bugs-text"
60 attribute="__call__"/>60 attribute="__call__"/>
61 <browser:page61 <browser:page
62 for="lp.registry.interfaces.projectgroup.IProjectGroup"
63 class="lp.bugs.browser.bugtask.TextualBugTaskSearchListingView"
64 permission="zope.Public"
65 name="+bugs-text"
66 attribute="__call__"/>
67 <browser:page
62 for="lp.bugs.interfaces.bugtarget.IHasBugs"68 for="lp.bugs.interfaces.bugtarget.IHasBugs"
63 class="lp.bugs.browser.bugtask.BugTaskSearchListingView"69 class="lp.bugs.browser.bugtask.BugTaskSearchListingView"
64 permission="zope.Public"70 permission="zope.Public"
6571
=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-text-pages.txt'
--- lib/lp/bugs/stories/bugs/xx-bug-text-pages.txt 2010-06-03 21:49:47 +0000
+++ lib/lp/bugs/stories/bugs/xx-bug-text-pages.txt 2010-06-25 13:44:30 +0000
@@ -281,6 +281,14 @@
281 >>> print anon_browser.contents281 >>> print anon_browser.contents
282 10282 10
283283
284This page is also available for project groups.
285
286 >>> anon_browser.open('http://launchpad.dev/mozilla/+bugs-text')
287 >>> print anon_browser.contents
288 15
289 5
290 4
291
284292
285== Private bugs ==293== Private bugs ==
286294