Merge lp:~acysos-team/banking-addons/banking-addons-spain-party-identifier into lp:banking-addons
Proposed by
Ignacio Ibeas (www.acysos.com)
Status: | Merged |
---|---|
Approved by: | Holger Brunn (Therp) |
Approved revision: | 227 |
Merged at revision: | 229 |
Proposed branch: | lp:~acysos-team/banking-addons/banking-addons-spain-party-identifier |
Merge into: | lp:banking-addons |
Diff against target: |
18 lines (+6/-2) 1 file modified
account_banking_pain_base/company.py (+6/-2) |
To merge this branch: | bzr merge lp:~acysos-team/banking-addons/banking-addons-spain-party-identifier |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Holger Brunn (Therp) | code review | Approve | |
Guewen Baconnier @ Camptocamp | Approve | ||
Pedro Manuel Baeza | code review | Approve | |
Review via email: mp+206246@code.launchpad.net |
Description of the change
Hello,
Add the party identifier support for Spain.
Greetings
To post a comment you must log in.
As you have added another condition, and to accomodate other countries, code can be refactored to:
if company: vat[0:2] .upper( )
party_ identifier = company_ vat[2:] .replace( ' ', '')
party_ identifier = company. sepa_creditor_ identifier
country_code = company_
if country_code == 'BE':
elif country_code == 'ES':
Regards.