Merge lp:~achiang/laika/status_fix into lp:laika

Proposed by Alex Chiang
Status: Merged
Merged at revision: 13
Proposed branch: lp:~achiang/laika/status_fix
Merge into: lp:laika
Diff against target: 49 lines (+15/-3)
1 file modified
laika (+15/-3)
To merge this branch: bzr merge lp:~achiang/laika/status_fix
Reviewer Review Type Date Requested Status
Paul Hummer (community) Approve
Review via email: mp+40266@code.launchpad.net

Commit message

Search launchpad for all statuses, not just the default statuses returned by searchTask().

This change gives us a more complete picture of our launchpad activity within the window.

Description of the change

Search launchpad for all statuses, not just the default statuses returned by searchTask().

This change gives us a more complete picture of our launchpad activity within the window.

To post a comment you must log in.
Revision history for this message
Paul Hummer (rockstar) wrote :

The status list has some funky indentation, but other than that, this looks fine to me. I wonder if you should file a bug that indicates that you shouldn't have to maintain this list yourself.

review: Approve
lp:~achiang/laika/status_fix updated
14. By Alex Chiang

Fix whitespace in status list.

Revision history for this message
Alex Chiang (achiang) wrote :

Thank you for the review.

I filed this:

https://bugs.launchpad.net/bugs/672883

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'laika'
--- laika 2010-10-21 17:19:42 +0000
+++ laika 2010-11-09 03:58:41 +0000
@@ -44,6 +44,15 @@
44 self.user = self.launchpad.people[user]44 self.user = self.launchpad.people[user]
45 self.window = window45 self.window = window
46 self.ppas = ppas46 self.ppas = ppas
47 self.status = ["New",
48 "Incomplete",
49 "Invalid",
50 "Won't Fix",
51 "Confirmed",
52 "Triaged",
53 "In Progress",
54 "Fix Committed",
55 "Fix Released" ]
4756
48 def print_header(self, header):57 def print_header(self, header):
49 print "==", header, "=="58 print "==", header, "=="
@@ -85,7 +94,8 @@
85 statuses = ['closed', 'fix_released', 'fix_committed',94 statuses = ['closed', 'fix_released', 'fix_committed',
86 'in_progress', 'triaged', 'confirmed', 'created']95 'in_progress', 'triaged', 'confirmed', 'created']
8796
88 tasks = self.user.searchTasks(assignee=self.user)97 tasks = self.user.searchTasks(assignee=self.user,
98 status=self.status)
89 self.print_header("Assigned Bugs")99 self.print_header("Assigned Bugs")
90100
91 for t in tasks:101 for t in tasks:
@@ -109,7 +119,8 @@
109 print119 print
110120
111 def print_comments(self):121 def print_comments(self):
112 tasks = self.user.searchTasks(bug_commenter=self.user)122 tasks = self.user.searchTasks(bug_commenter=self.user,
123 status=self.status)
113 self.print_header("Commented Bugs")124 self.print_header("Commented Bugs")
114 for t in tasks:125 for t in tasks:
115 if self.bugs.has_key(t.bug.id):126 if self.bugs.has_key(t.bug.id):
@@ -124,7 +135,8 @@
124 print135 print
125136
126 def print_reported(self):137 def print_reported(self):
127 tasks = self.user.searchTasks(bug_reporter=self.user)138 tasks = self.user.searchTasks(bug_reporter=self.user,
139 status=self.status)
128 self.print_header("Reported Bugs")140 self.print_header("Reported Bugs")
129 for t in tasks:141 for t in tasks:
130 if self.bugs.has_key(t.bug.id):142 if self.bugs.has_key(t.bug.id):

Subscribers

People subscribed via source and target branches

to all changes: