Merge lp:~abreu-alexandre/cordova-ubuntu/3.4-arch-packaging into lp:~dholbach/cordova-ubuntu/3.4-packaging

Proposed by Alexandre Abreu
Status: Merged
Merged at revision: 17
Proposed branch: lp:~abreu-alexandre/cordova-ubuntu/3.4-arch-packaging
Merge into: lp:~dholbach/cordova-ubuntu/3.4-packaging
Diff against target: 43 lines (+4/-7)
3 files modified
debian/README.Debian (+1/-1)
debian/control (+2/-5)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/cordova-ubuntu/3.4-arch-packaging
Reviewer Review Type Date Requested Status
Daniel Holbach Approve
David Barth (community) Approve
Review via email: mp+206794@code.launchpad.net

This proposal supersedes a proposal from 2014-02-17.

Description of the change

Update the package install data, to:

- change the name of the package to something less cordova specific,
- install the runtime bits in arch specific paths already,

The other bit (qtc side) of this MR is there:

https://code.launchpad.net/~abreu-alexandre/qtcreator-plugin-ubuntu/cordova-runtime-copy-script-pkg-rename

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote : Posted in a previous version of this proposal

Did you really mean to commit so many files under build/ ? this diff is huge... surely those files are generated and don't need to be committed?

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote : Posted in a previous version of this proposal

> Did you really mean to commit so many files under build/ ? this diff is
> huge... surely those files are generated and don't need to be committed?

oops ... wrong target branch

Revision history for this message
David Barth (dbarth) wrote :

+1

review: Approve
Revision history for this message
Daniel Holbach (dholbach) wrote :

I think this changed should have gone to lp:cordova-ubuntu/container instead? I'm happy to propose a merge to speed things up.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/README.Debian'
--- debian/README.Debian 2014-02-13 14:00:46 +0000
+++ debian/README.Debian 2014-02-17 19:09:28 +0000
@@ -1,4 +1,4 @@
1The files in /usr/share/cordova-ubuntu-3.4/ are not meant to be used 1The files in /usr/share/ubuntu-html5-platform-3.4/ are not meant to be used
2locally, but are to be shipped in the resulting click packages.2locally, but are to be shipped in the resulting click packages.
33
4This means that each click package which uses cordova-ubuntu-3.4 will ship4This means that each click package which uses cordova-ubuntu-3.4 will ship
55
=== modified file 'debian/control'
--- debian/control 2014-02-13 23:26:33 +0000
+++ debian/control 2014-02-17 19:09:28 +0000
@@ -23,15 +23,12 @@
23# upstream branch23# upstream branch
24Vcs-Bzr: lp:cordova-ubuntu/3.424Vcs-Bzr: lp:cordova-ubuntu/3.4
2525
26Package: cordova-ubuntu-3.4-dev26Package: ubuntu-html5-platform-3.4-dev
27Section: libdevel27Section: libdevel
28Architecture: any28Architecture: any
29Depends: ${misc:Depends},29Depends: ${misc:Depends},
30 ${shlibs:Depends},30 ${shlibs:Depends},
31Description: Cordova Framework for building mobile web apps - development files31Description: Ubuntu HTML5 Framework for building mobile web apps - development files
32 Cordova is a free and open source framework that allows you to create mobile
33 apps using standardized web APIs for the platforms you care about.
34 .
35 This package contains files that are needed to build applications.32 This package contains files that are needed to build applications.
36 .33 .
37 They are not meant to be used locally, but are embedded in the resulting34 They are not meant to be used locally, but are embedded in the resulting
3835
=== modified file 'debian/rules'
--- debian/rules 2014-02-14 07:22:25 +0000
+++ debian/rules 2014-02-17 19:09:28 +0000
@@ -4,7 +4,7 @@
4DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)4DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
55
6override_dh_auto_configure:6override_dh_auto_configure:
7 cd build; cmake -DCMAKE_INSTALL_PREFIX=/usr/share/cordova-ubuntu-3.4 \7 cd build; cmake -DCMAKE_INSTALL_PREFIX=/usr/share/ubuntu-html5-platform-3.4/${DEB_HOST_MULTIARCH} \
8 -DCMAKE_VERBOSE_MAKEFILE=ON \8 -DCMAKE_VERBOSE_MAKEFILE=ON \
9 -DCMAKE_BUILD_TYPE=RelWithDebInfo9 -DCMAKE_BUILD_TYPE=RelWithDebInfo
1010

Subscribers

People subscribed via source and target branches