Merge lp:~abreu-alexandre/click/clean-trust-dbs-on-package-removal into lp:click

[Alexandre Abreu]

Clean the trust DB store for the location service as click apps are being removed. This is not an optimal solution and is rather static but will work until click becomes deprecated.

Clean the trust DB store for the location service as click apps are being removed. This is not an optimal solution and is rather static but will work until click becomes deprecated.

[Colin Watson (cjwatson)]

review: Needs Fixing

[lp:~abreu-alexandre/click/clean-trust-dbs-on-package-removal]

609. By Alexandre Abreu on 2016-07-07

Tweaks

[Alexandre Abreu (abreu-alexandre)]

udated

[Colin Watson (cjwatson)]

Looks good now provided that mentions of click_stderr in this diff are removed properly.

review: Approve

[lp:~abreu-alexandre/click/clean-trust-dbs-on-package-removal]

610. By Alexandre Abreu on 2016-07-08

remove unused error vars

611. By Alexandre Abreu on 2016-07-11

Cleanup all trust store DBs

Unmerged revisions

611. By Alexandre Abreu on 2016-07-11

Cleanup all trust store DBs

610. By Alexandre Abreu on 2016-07-08

remove unused error vars

609. By Alexandre Abreu on 2016-07-07

Tweaks

608. By Alexandre Abreu on 2016-07-07

Fix purge command line

607. By David Barth on 2016-07-07

add function to purge trust-store dbs (prototype stage)

=== modified file 'pk-plugin/pk-plugin-click.c'
--- pk-plugin/pk-plugin-click.c	2014-10-08 13:58:34 +0000
+++ pk-plugin/pk-plugin-click.c	2016-07-11 14:36:50 +0000
@@ -623,6 +623,58 @@
 	json_array_unref (array);
 }
 
+/* Fix for #1586737 - [CTA]privacies/permissions are not removed after the app
+   has been uninstalled
+*/
+
+static void
+trust_db_purge_for_service (const gchar *package_id, const gchar *service_name)
+{
+	gchar **argv = NULL;
+	gint i;
+	gchar **envp = NULL;
+
+	argv = g_malloc0_n (6, sizeof (*argv));
+	i = 0;
+
+	argv[i++] = g_strdup ("trust-store-cleaner");
+	argv[i++] = g_strdup ("--for-service");
+	argv[i++] = g_strdup (service_name);
+	argv[i++] = g_strdup ("--purge");
+	argv[i++] = g_strdup (package_id);
+
+	/* TODO: iterate over each well-known trust store services */
+	envp = click_get_envp ();
+	g_spawn_sync (NULL, argv, envp,
+		      G_SPAWN_SEARCH_PATH
+		       | G_SPAWN_STDOUT_TO_DEV_NULL
+		       | G_SPAWN_STDERR_TO_DEV_NULL,
+		      NULL, NULL, NULL,
+		      NULL, NULL, NULL);
+	/* Note: we ignore errors, as we don't want the uninstall to fail for that reason */
+
+	g_strfreev (argv);
+	g_strfreev (envp);
+}
+
+static void
+trust_db_purge(const gchar *package_id)
+{
+	static gchar* service_names[] = {
+		"UbuntuLocationService",
+		"CameraService",
+		"PulseAudio",
+		"InAppPurchases"
+	};
+	int i;
+
+	for (i = 0;
+	     i < sizeof(service_names) / sizeof(service_names[0]);
+	     ++i) {
+		trust_db_purge_for_service(package_id, service_names[i]);
+	}
+}
+
 static gboolean
 click_remove_package (PkPlugin *plugin, PkTransaction *transaction,
 		      const gchar *package_id)
@@ -702,6 +754,9 @@
 				summary, error->message);
 		goto out;
 	}
+
+	trust_db_purge (package_id);
+
 	/* TODO: remove data? */
 	ret = TRUE;