Merge lp:~abentley/workspace-runner/s3-script into lp:workspace-runner
Proposed by
Aaron Bentley
Status: | Merged |
---|---|
Merged at revision: | 20 |
Proposed branch: | lp:~abentley/workspace-runner/s3-script |
Merge into: | lp:workspace-runner |
Diff against target: |
181 lines (+172/-0) 2 files modified
workspace_runner/tests/test_upload_artifacts.py (+123/-0) workspace_runner/upload_artifacts.py (+49/-0) |
To merge this branch: | bzr merge lp:~abentley/workspace-runner/s3-script |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
John George (community) | Approve | ||
Review via email: mp+263383@code.launchpad.net |
Commit message
Provide a script that uploads to s3.
Description of the change
This branch provides the upload_artifacts script, which will typically be run remotely, but is tested locally.
It uses a JSON file for data. (JSON so that it doesn't require external dependencies.)
It doesn't currently pay attention to MIME types, but I plan to address that in future branch.
In a the follow-on branch, the workspace runner is taught to dump this JSON, upload it and the script to the remote machine, and run the script.
To post a comment you must log in.
Would you please add help= to add_arguments() in upload_ artifacts. py, other than that it looks good.