Merge lp:~abentley/launchpad/process-upload-no-cwd into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 11085 |
Proposed branch: | lp:~abentley/launchpad/process-upload-no-cwd |
Merge into: | lp:launchpad |
Diff against target: |
194 lines (+89/-7) 4 files modified
lib/lp/archiveuploader/dscfile.py (+1/-1) lib/lp/archiveuploader/tests/test_dscfile.py (+21/-2) lib/lp/testing/__init__.py (+20/-3) lib/lp/testing/factory.py (+47/-1) |
To merge this branch: | bzr merge lp:~abentley/launchpad/process-upload-no-cwd |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Hummer (community) | code | Approve | |
Review via email: mp+28682@code.launchpad.net |
Description of the change
= Summary =
Fix bug #595957: archive uploader tries to move the changelog to the current
working directory
== Proposed fix ==
Stop specifying where to create the temp directory.
== Pre-implementation notes ==
None
== Implementation details ==
In the process, I had to create a way to create DSCFiles. This meant using a
temp directory in the LaunchpadObject
Therefore, I extracted a temp_dir context manager and useContext from
useTempDir.
== Tests ==
bin/test -t test_ReadOnlyCWD
== Demo and Q/A ==
None
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Looks good. Just so you know, I went through this and followed the code in my head. I'm not letting you off easy, you just write good code.
Also, I now have it on my TODO list to read up on contextlib.