Merge lp:~aacid/unity-2d/greek_chars_lens_activate into lp:unity-2d

Proposed by Albert Astals Cid
Status: Merged
Approved by: Gerry Boland
Approved revision: 1104
Merged at revision: 1110
Proposed branch: lp:~aacid/unity-2d/greek_chars_lens_activate
Merge into: lp:unity-2d
Diff against target: 35 lines (+16/-1)
2 files modified
libunity-2d-private/src/lens.cpp (+1/-1)
tests/manual-tests/dash.txt (+15/-0)
To merge this branch: bzr merge lp:~aacid/unity-2d/greek_chars_lens_activate
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+107052@code.launchpad.net

Commit message

[lib] Convert the percent encoded string to a form UnityCore understands

Description of the change

[lib] Convert the percent encoded string to a form UnityCore understands

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Ok, I've tested this with as many unusual characters as I could assemble, it looks to be fine. Approving, thank you!

review: Approve
Revision history for this message
Gerry Boland (gerboland) wrote :

Ok, I've tested this with as many unusual characters as I could assemble, it looks to be fine. Approving, thank you!

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

Attempt to merge into lp:unity-2d failed due to conflicts:

text conflict in tests/manual-tests/dash.txt

1104. By Albert Astals Cid

Merge lp:unity-2d

Revision history for this message
Albert Astals Cid (aacid) wrote :

Merged with lp:unity-2d to solve conflict in tests/manual-tests/dash.txt

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libunity-2d-private/src/lens.cpp'
--- libunity-2d-private/src/lens.cpp 2012-03-29 12:27:21 +0000
+++ libunity-2d-private/src/lens.cpp 2012-05-29 07:31:19 +0000
@@ -175,7 +175,7 @@
175175
176void Lens::activate(const QString& uri)176void Lens::activate(const QString& uri)
177{177{
178 m_unityLens->Activate(uri.toStdString());178 m_unityLens->Activate(QByteArray::fromPercentEncoding(uri.toUtf8()).constData());
179}179}
180180
181void Lens::onActivated(std::string const& uri, unity::dash::HandledType type, unity::dash::Lens::Hints const&)181void Lens::onActivated(std::string const& uri, unity::dash::HandledType type, unity::dash::Lens::Hints const&)
182182
=== modified file 'tests/manual-tests/dash.txt'
--- tests/manual-tests/dash.txt 2012-05-24 11:22:11 +0000
+++ tests/manual-tests/dash.txt 2012-05-29 07:31:19 +0000
@@ -261,3 +261,18 @@
261 # * Verify dash can be maximized in the first monitor (that is not the primary anymore)261 # * Verify dash can be maximized in the first monitor (that is not the primary anymore)
262262
263-----263-----
264
265# Test case objectives:
266 # * Ensure files inside folders with greek names open correctly
267 # Pre-conditions
268 # * Have a folder with greek characters like Παράδειγμα
269 # * Have a file called THIS_IS_A_TEST_FOR_GREEK_CHARS inside that folder
270 # * Open that file from nautilus so it will show up in the files dash
271 # Test steps
272 # * Open Dash
273 # * Go to the files dash
274 # * Type THIS_IS_A_TEST_FOR_GREEK_CHARS
275 # * Open the file from the dash
276 # * Verify the file really opens
277
278-----

Subscribers

People subscribed via source and target branches