Merge lp:~3v1n0/unity/lockscreen-promptview-scaling-fix into lp:unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 4088
Proposed branch: lp:~3v1n0/unity/lockscreen-promptview-scaling-fix
Merge into: lp:unity
Diff against target: 61 lines (+1/-6)
5 files modified
lockscreen/KylinUserPromptView.cpp (+0/-1)
lockscreen/KylinUserPromptView.h (+0/-2)
lockscreen/LockScreenAbstractPromptView.h (+1/-0)
lockscreen/UserPromptView.cpp (+0/-1)
lockscreen/UserPromptView.h (+0/-2)
To merge this branch: bzr merge lp:~3v1n0/unity/lockscreen-promptview-scaling-fix
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+289162@code.launchpad.net

Commit message

UserPromptView: don't hide local scale property

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrea Azzarone (azzar1) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lockscreen/KylinUserPromptView.cpp'
--- lockscreen/KylinUserPromptView.cpp 2016-01-15 01:41:04 +0000
+++ lockscreen/KylinUserPromptView.cpp 2016-03-16 10:58:25 +0000
@@ -81,7 +81,6 @@
8181
82KylinUserPromptView::KylinUserPromptView(session::Manager::Ptr const& session_manager)82KylinUserPromptView::KylinUserPromptView(session::Manager::Ptr const& session_manager)
83 : AbstractUserPromptView(session_manager)83 : AbstractUserPromptView(session_manager)
84 , scale(1.0)
85 , session_manager_(session_manager)84 , session_manager_(session_manager)
86 , username_(nullptr)85 , username_(nullptr)
87 , msg_layout_(nullptr)86 , msg_layout_(nullptr)
8887
=== modified file 'lockscreen/KylinUserPromptView.h'
--- lockscreen/KylinUserPromptView.h 2015-12-07 03:09:28 +0000
+++ lockscreen/KylinUserPromptView.h 2016-03-16 10:58:25 +0000
@@ -46,8 +46,6 @@
46public:46public:
47 KylinUserPromptView(session::Manager::Ptr const& session_manager);47 KylinUserPromptView(session::Manager::Ptr const& session_manager);
4848
49 nux::Property<double> scale;
50
51 nux::View* focus_view();49 nux::View* focus_view();
5250
53 void AddAvatar(std::string const& avatar_icon, int avatar_size);51 void AddAvatar(std::string const& avatar_icon, int avatar_size);
5452
=== modified file 'lockscreen/LockScreenAbstractPromptView.h'
--- lockscreen/LockScreenAbstractPromptView.h 2015-12-07 03:09:28 +0000
+++ lockscreen/LockScreenAbstractPromptView.h 2016-03-16 10:58:25 +0000
@@ -50,6 +50,7 @@
50public:50public:
51 AbstractUserPromptView(session::Manager::Ptr const& session_manager)51 AbstractUserPromptView(session::Manager::Ptr const& session_manager)
52 : nux::View(NUX_TRACKER_LOCATION)52 : nux::View(NUX_TRACKER_LOCATION)
53 , scale(1.0)
53 , session_manager_(session_manager)54 , session_manager_(session_manager)
54 {}55 {}
5556
5657
=== modified file 'lockscreen/UserPromptView.cpp'
--- lockscreen/UserPromptView.cpp 2016-01-15 01:41:04 +0000
+++ lockscreen/UserPromptView.cpp 2016-03-16 10:58:25 +0000
@@ -101,7 +101,6 @@
101101
102UserPromptView::UserPromptView(session::Manager::Ptr const& session_manager)102UserPromptView::UserPromptView(session::Manager::Ptr const& session_manager)
103 : AbstractUserPromptView(session_manager)103 : AbstractUserPromptView(session_manager)
104 , scale(1.0)
105 , session_manager_(session_manager)104 , session_manager_(session_manager)
106 , username_(nullptr)105 , username_(nullptr)
107 , msg_layout_(nullptr)106 , msg_layout_(nullptr)
108107
=== modified file 'lockscreen/UserPromptView.h'
--- lockscreen/UserPromptView.h 2015-11-23 09:24:10 +0000
+++ lockscreen/UserPromptView.h 2016-03-16 10:58:25 +0000
@@ -50,8 +50,6 @@
50public:50public:
51 UserPromptView(session::Manager::Ptr const& session_manager);51 UserPromptView(session::Manager::Ptr const& session_manager);
5252
53 nux::Property<double> scale;
54
55 nux::View* focus_view();53 nux::View* focus_view();
5654
57 void AddPrompt(std::string const& message, bool visible, PromiseAuthCodePtr const&);55 void AddPrompt(std::string const& message, bool visible, PromiseAuthCodePtr const&);