Merge lp:~3v1n0/ubuntu-settings-components/cmake-find-pkg into lp:ubuntu-settings-components

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 177
Merged at revision: 177
Proposed branch: lp:~3v1n0/ubuntu-settings-components/cmake-find-pkg
Merge into: lp:ubuntu-settings-components
Diff against target: 28 lines (+3/-3)
3 files modified
plugins/CMakeLists.txt (+1/-1)
tests/qmltests/mocks/CMakeLists.txt (+1/-1)
tests/utils/modules/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~3v1n0/ubuntu-settings-components/cmake-find-pkg
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Unity Team Pending
Review via email: mp+313768@code.launchpad.net

Commit message

CMake: use find_package(QmlPlugins) instead of include(QmlPlugins)

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:177
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/121/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3628
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2074
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2074
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3656
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3502
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3502/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3502
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3502/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3502
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3502/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3502
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3502/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3502
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3502/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3502
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3502/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/121/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/CMakeLists.txt'
--- plugins/CMakeLists.txt 2015-04-09 12:58:23 +0000
+++ plugins/CMakeLists.txt 2016-12-22 14:37:25 +0000
@@ -1,4 +1,4 @@
1include(QmlPlugins)1find_package(QmlPlugins)
22
3macro(add_usc_plugin PLUGIN VERSION PATH)3macro(add_usc_plugin PLUGIN VERSION PATH)
4 export_qmlfiles(${PLUGIN} ${PATH} DESTINATION ${QT_IMPORTS_DIR} ${ARGN})4 export_qmlfiles(${PLUGIN} ${PATH} DESTINATION ${QT_IMPORTS_DIR} ${ARGN})
55
=== modified file 'tests/qmltests/mocks/CMakeLists.txt'
--- tests/qmltests/mocks/CMakeLists.txt 2016-08-17 10:19:32 +0000
+++ tests/qmltests/mocks/CMakeLists.txt 2016-12-22 14:37:25 +0000
@@ -1,4 +1,4 @@
1include(QmlPlugins)1find_package(QmlPlugins)
22
3# Set up and optionally install a mock plugin for ubuntu-settings-components.3# Set up and optionally install a mock plugin for ubuntu-settings-components.
4#4#
55
=== modified file 'tests/utils/modules/CMakeLists.txt'
--- tests/utils/modules/CMakeLists.txt 2016-01-29 00:46:56 +0000
+++ tests/utils/modules/CMakeLists.txt 2016-12-22 14:37:25 +0000
@@ -1,3 +1,3 @@
1include(QmlPlugins)1find_package(QmlPlugins)
22
3add_subdirectory(Ubuntu)3add_subdirectory(Ubuntu)

Subscribers

People subscribed via source and target branches