Merge lp:~3v1n0/gnome-session/remove-scale-factor-migration into lp:~ubuntu-desktop/gnome-session/ubuntu

Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 449
Proposed branch: lp:~3v1n0/gnome-session/remove-scale-factor-migration
Merge into: lp:~ubuntu-desktop/gnome-session/ubuntu
Diff against target: 35 lines (+0/-19)
1 file modified
debian/unity-gnome-shell-migration.18.08.py (+0/-19)
To merge this branch: bzr merge lp:~3v1n0/gnome-session/remove-scale-factor-migration
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+331726@code.launchpad.net

Commit message

unity-gnome-shell-migration.18.08: remove scaling factor reset

This will be done at unity level, only in the case unity is installed then

To post a comment you must log in.
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Didier, please update gnome-session to 3.26.1 when you upload this.

https://git.gnome.org/browse/gnome-session/log?h=gnome-3-26

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I'll merge and upload this with another gnome-session change I need to do (it can land independently of the other changes).

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Let's merge this meanwhile

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/unity-gnome-shell-migration.18.08.py'
--- debian/unity-gnome-shell-migration.18.08.py 2017-08-17 07:42:38 +0000
+++ debian/unity-gnome-shell-migration.18.08.py 2017-10-03 17:03:03 +0000
@@ -60,17 +60,6 @@
60 gs_settings.sync() # force sync to avoid race60 gs_settings.sync() # force sync to avoid race
6161
6262
63def reset_scaling_factor():
64
65 gs_settings = Gio.Settings.new("org.gnome.desktop.interface")
66 for key in ["cursor-size", "scaling-factor", "text-scaling-factor"]:
67 if not gs_settings.is_writable(key):
68 print("Can't reset factor-reset key '%s': in read only." % key)
69 continue
70 gs_settings.reset(key)
71 gs_settings.sync() # force sync to avoid race
72
73
74def migrate_launcher_properties():63def migrate_launcher_properties():
75 unity_settings = Gio.Settings.new_with_path(UNITY_COMPIZ_LAUNCHER_SETTINGS, UNITY_COMPIZ_LAUNCHER_SETTINGS_PATH)64 unity_settings = Gio.Settings.new_with_path(UNITY_COMPIZ_LAUNCHER_SETTINGS, UNITY_COMPIZ_LAUNCHER_SETTINGS_PATH)
76 dock_settings = Gio.Settings.new(DOCK_SETTINGS)65 dock_settings = Gio.Settings.new(DOCK_SETTINGS)
@@ -101,13 +90,5 @@
101 print("Unity or GNOME Shell not installed: no migration needed")90 print("Unity or GNOME Shell not installed: no migration needed")
102 sys.exit(0)91 sys.exit(0)
10392
104 # Only run that in the ubuntu/ubuntu-wayland main sessions
105 # (we don't want to reset scale factor for people who
106 # continue to run unity)
107 current_session = os.getenv("DESKTOP_SESSION", "")
108 if current_session not in ("ubuntu", "ubuntu-wayland"):
109 sys.exit(0)
110
111 migrate_unity_launchers()93 migrate_unity_launchers()
112 migrate_launcher_properties()94 migrate_launcher_properties()
113 reset_scaling_factor()

Subscribers

People subscribed via source and target branches