Merge lp:~0k.io/ocb-server/usability-and-fix-on-res-partner-1 into lp:ocb-server

[Nicolas JEUDY]

In OpenERP V7 there is some bugs/usability issue when using res.partner and contact.

- On supplier, if you create a contact directly from the parent form, the supplier checkbox is not invisible.
- If you save contact, supplier and customer checkbox should be the same as parent.
- Title field is not shown
- etc ..

Here is a fix and my first merge proposal to OCB server. hope it is ok and feel free to ask me if I can do better

[Holger Brunn (Therp) (hbrunn)]

Please always link a bug report to merge proposals to the ocb branches.

Further, given that your changes make a lot of sense to me, it's worth a try to also propose your change to upstream. If they won't pick it up in due time, we'll merge it into the ocb branches.

review: Needs Fixing

[Holger Brunn (Therp) (hbrunn)]

What do other ocb-commiters think about this one?

[Stefan Rijnhart (Opener) (stefan-opener)]

Agreed that we need a bug report to establish what this code fixes exactly (although I get an idea when I read the code) and to link the ocb proposal and the upstream proposal to (if it exists, which is mandatory).

[Pedro Manuel Baeza (pedro.baeza)]

Yeah, I agree with both Holger and Stefan. I have faced the same problem, but it is necessary to fill a bug on openobject-addons project with the proposed fix and let OpenERP S. A. decide if they include it on official branch, and if not, then merge it here.

Regards.

[Nicolas JEUDY (njeudy)]

I will report a bug on addons before. and then link this merge to the new bug.

[Nicolas JEUDY (njeudy)]

Hello,

I create a bug On OpenERP server with a video and link this branch. Is it ok for you ?

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Nicolas, thank you very much for the bug report. There is one more thing you can do: propose the same patch in openobject-addons project so that OpenERP S. A. can evaluate if the patch is correct and then merge on the official branch more quickly.

Regards.

[Pedro Manuel Baeza (pedro.baeza)]

Sorry, I was mean to say openobject-server.

Regards.

[Nicolas JEUDY (njeudy)]

Ok, I will do this. I think I have to do a special branch for
openobject-server ;)

Nicolas JEUDY

Expert Technique et Fonctionnel Système d'Information
TUXSERVICES

22 rue du seminaire - 25170 Pelousey
e-mail : <email address hidden>
mob. : [phone]
http://www.tuxservices.com

2013/11/5 Pedro Manuel Baeza <email address hidden>

> Sorry, I was mean to say openobject-server.
>
> Regards.
> --
>
> https://code.launchpad.net/~0k.io/ocb-server/usability-and-fix-on-res-partner-1/+merge/185339
> Your team 0k.io is subscribed to branch lp:~
> 0k.io/ocb-server/usability-and-fix-on-res-partner-1.
>

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Given the discussions, I put this MP as 'work in progress'. Please set it back to 'Needs review' once ready.

Unmerged revisions

5092. By Nicolas JEUDY on 2013-09-12

FIX: Improve res.partner form for better @usability with:

- fix customer and supplier boolean field that should be the same as his parent by default
- Add title field on contact form
- Change some css stuff for better form usability.
- mark customer and supplier checkbox as invisible on contact form.

=== modified file 'openerp/addons/base/res/res_partner_view.xml'
--- openerp/addons/base/res/res_partner_view.xml	2013-06-07 16:20:45 +0000
+++ openerp/addons/base/res/res_partner_view.xml	2013-09-12 18:48:51 +0000
@@ -186,7 +186,7 @@
 
                     <notebook colspan="4">
                         <page string="Contacts" attrs="{'invisible': [('is_company','=',False), ('child_ids', '=', [])]}" autofocus="autofocus">
-                            <field name="child_ids" mode="kanban" context="{'default_parent_id': active_id, 'default_street': street, 'default_street2': street2, 'default_city': city, 'default_state_id': state_id, 'default_zip': zip, 'default_country_id': country_id, 'default_supplier': supplier}">
+                            <field name="child_ids" mode="kanban" context="{'default_parent_id': active_id, 'default_street': street, 'default_street2': street2, 'default_city': city, 'default_state_id': state_id, 'default_zip': zip, 'default_country_id': country_id, 'default_customer': customer, 'default_supplier': supplier}">
                                 <kanban>
                                     <field name="color"/>
                                     <field name="name"/>
@@ -233,8 +233,8 @@
                                                                 <tr>
                                                                     <td class="oe_kanban_title1" align="left" valign="middle">
                                                                         <h4><a type="open"><field name="name"/></a></h4>
-                                                                        <i><div t-if="record.function.raw_value">
-                                                                            <field name="function"/></div></i>
+                                                                        <div t-if="record.function.raw_value">
+                                                                                <i><field name="function"/></i></div>
                                                                         <div><a t-if="record.email.raw_value" title="Mail" t-att-href="'mailto:'+record.email.value">
                                                                             <field name="email"/>
                                                                         </a></div>
@@ -254,10 +254,10 @@
                                 <form string="Contact" version="7.0">
                                     <sheet>
                                         <field name="image" widget='image' class="oe_avatar oe_left" options='{"preview_image": "image_medium"}'/>
-                                        <div class="oe_title">
+                                        <div name="title">
                                             <label for="name" class="oe_edit_only"/>
-                                            <h1><field name="name" style="width: 70%%"/></h1>
-                                            <field name="category_id" widget="many2many_tags" placeholder="Tags..." style="width: 70%%"/>
+                                            <h1><field name="title" placeholder="title" style="width: 20%%"/><field name="name" style="width: 70%%"/></h1>
+                                            <field name="category_id" widget="many2many_tags" placeholder="Tags..." style="width: 100%%"/>
                                         </div>
                                         <group>
                                             <field name="function" placeholder="e.g. Sales Director"/>
@@ -285,7 +285,9 @@
                                                 <field name="country_id" placeholder="Country" class="oe_no_button" options='{"no_open": True}'/>
                                             </div>
                                         </group>
-                                        <field name="supplier" invisible="True"/>
+                                        <field name="supplier" invisible="1"/>
+                                        <field name="customer" invisible="1"/>
+
                                     </sheet>
                                 </form>
                             </field>