Code review comment for lp:~verterok/charms/trusty/haproxy/restart-rsyslog-after-install

Revision history for this message
Andrew McLeod (admcleod) wrote :

Hi Guillermo,

I manually deployed as per the amulet test and: haproxy restart worked, socketfile defined in /etc/rsyslog.d/haproxy.conf exists, /var/log/haproxy.log exists,

However, I ran into problems with running bundletester against this update:

Checking for Python syntax...
/tmp/bundletester-DsZsMg/haproxy/hooks/tests/test_reverseproxy_hooks.py:17:80: E501 line too long (101 > 79 characters)
make: *** [lint] Error 1

I fixed this manually and then ran into this:

http://pastebin.ubuntu.com/12207030/

I managed to get past these issues once (randomly), and although 49-haproxy.conf exists and the restart occurs according to debug logs, there is no socketfile and no /var/log/haproxy.log.

http://pastebin.ubuntu.com/12207109/ (clock differences in container and local machine)

Looks like its probably just a test problem which needs to be resolved

review: Needs Fixing

« Back to merge proposal