Code review comment for lp:~stefanor/ibid/exchange-825217

Revision history for this message
Max Rabkin (max-rabkin) wrote :

Some non-currencies are missing (search http://en.wikipedia.org/wiki/ISO_4217 for "funds code" for some more -- the funds codes are in table A.2 of the standard, we may be able to use this instead of hard coding).

You should use trial's tempdir functions instead of hardcoding /tmp.

The tests are networking tesst but it don't check for IBID_NETWORKLESS_TEST.

review: Needs Fixing

« Back to merge proposal