Code review comment for lp:~silverdrake11/landscape-charm/log_upgrade_version

Revision history for this message
Mitch Burton (mitchburton) wrote :

test failure:

======================================================================
FAIL: test_action_upgrade (tests.test_charm.TestCharm)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/perfect5th/Canonical/src/landscape-charm/log_upgrade_version/tests/test_charm.py", line 894, in test_action_upgrade
    self.assertEqual(event.log.call_count, 5)
AssertionError: 9 != 5

Otherwise LGTM

review: Needs Fixing

« Back to merge proposal