Code review comment for lp:~pavel-pachkovskij/charms/precise/rack/trunk

Revision history for this message
Mark Mims (mark-mims) wrote :

Hey Pavel,

I have a couple of changes I'd like to see, but I'll file these as bug reports against the charm once we get these changes merged.

Before merging this one, could you please embed wayne's script into the bootstrap process rather than just `curl -L https://get.rvm.io | bash -s stable --ruby` please? I know this introduces some versioning issues, but it keeps the complete installation process under revision control.

I might do this myself later this week if you're still on vacation... I don't remember when you're back.

Thanks!
Mark

review: Needs Fixing

« Back to merge proposal