Merge lp:~paulliu/unity8/notification_helper into lp:unity8

[Ying-Chun Liu]

Add Autopilot Notification helper.

Implement helper based on
http://people.canonical.com/~thomir/ueqa-code-proposals/proposals/indicator-power/index.html

 * Are there any related MPs required for this MP to build/function as expected? Please list.
no
 * Did you perform an exploratory manual test run of your code change and any related functionality?
yes
 * Did you make sure that your branch does not contain spurious tags?
yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
 * If you changed the UI, has there been a design review?
N/A

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1594
http://jenkins.qa.ubuntu.com/job/unity8-ci/5272/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1276/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/436/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/437/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/437/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1274/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5272/rebuild

review: Needs Fixing (continuous-integration)

[lp:~paulliu/unity8/notification_helper]

1595. By Ying-Chun Liu on 2015-02-11

fix whitespace

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1595
http://jenkins.qa.ubuntu.com/job/unity8-ci/5278/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1284
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/442
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/443
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/443
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1135
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1282
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1282/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17951

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5278/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1595
http://jenkins.qa.ubuntu.com/job/unity8-ci/5279/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1285
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/443
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/444
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/444
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1136
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1283
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1283/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17953

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5279/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

There is tags that don't belong here, please fix

0.1+14.04.20140221-0ubuntu1 ?
0.1+14.04.20140306-0ubuntu1 ?
0.1+14.10.20140502-0ubuntu1 ?
0.2+14.10.20140701.2-0ubuntu1 ?
0.3+14.10.20140708-0ubuntu1 ?
0.4+14.10.20140918-0ubuntu1 ?
0.4+14.10.20140926-0ubuntu1 ?
0.4+15.04.20141104-0ubuntu1 ?
0.4+15.04.20141105-0ubuntu1 ?

review: Needs Fixing

[Allan LeSage (allanlesage)]

Some comments inline, let's get Leo's feedback too. . . .

review: Needs Fixing

[Leo Arias (elopio)]

review: Needs Fixing

[lp:~paulliu/unity8/notification_helper]

1596. By Ying-Chun Liu on 2015-02-13

Move to main_window.
Update test_notifications.

[Albert Astals Cid (aacid)]

Tags are gone, I'll leave the review up to Leo and Allan

review: Abstain

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1596
http://jenkins.qa.ubuntu.com/job/unity8-ci/5321/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1358
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/485
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/486
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/486
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1198
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1356
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1356/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18057

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5321/rebuild

review: Approve (continuous-integration)

[Leo Arias (elopio)]

Some minor pita style complaints.
This is good, thanks Paul!

review: Needs Fixing

[lp:~paulliu/unity8/notification_helper]

1597. By Ying-Chun Liu on 2015-02-17

Fix minor issues.

[Leo Arias (elopio)]

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1597
http://jenkins.qa.ubuntu.com/job/unity8-ci/5332/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1394
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/496
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/497
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/497
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1231
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1392
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1392/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18116

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5332/rebuild

review: Needs Fixing (continuous-integration)

[Allan LeSage (allanlesage)]

This is great, much cleaner, well done.

review: Approve

[Albert Astals Cid (aacid)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
No, it's a test change only and the users of the test code are happy :)

 * Did CI run pass?
No, known broken stuff

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

=== modified file 'tests/autopilot/unity8/shell/__init__.py'
--- tests/autopilot/unity8/shell/__init__.py	2015-01-21 13:50:14 +0000
+++ tests/autopilot/unity8/shell/__init__.py	2015-02-17 15:42:02 +0000
@@ -27,6 +27,7 @@
 
 logger = logging.getLogger(__name__)
 
+
 def disable_qml_mocking(fn):
     """Simple decorator that disables the QML mocks from being loaded."""
     @wraps(fn)

=== modified file 'tests/autopilot/unity8/shell/emulators/main_window.py'
--- tests/autopilot/unity8/shell/emulators/main_window.py	2015-01-21 04:11:36 +0000
+++ tests/autopilot/unity8/shell/emulators/main_window.py	2015-02-17 15:42:02 +0000
@@ -174,3 +174,20 @@
             'PinPadButton',
             objectName='pinPadButton{}'.format(button_id)
         )
+
+    @autopilot_logging.log_action(logger.info)
+    def wait_for_notification(self):
+        """Wait for a notification dialog to appear.
+
+        :return: An object for the notification dialog data.
+        :raise StateNotFoundError: if the timeout expires when the
+        notification has not appeared.
+
+        """
+        notify_list = self.select_single('Notifications',
+                                         objectName='notificationList')
+        visible_notification = notify_list.wait_select_single('Notification',
+                                                              visible=True)
+        return {'summary': visible_notification.summary,
+                'body': visible_notification.body,
+                'iconSource': visible_notification.iconSource}

=== modified file 'tests/autopilot/unity8/shell/tests/test_notifications.py'
--- tests/autopilot/unity8/shell/tests/test_notifications.py	2014-10-31 10:08:38 +0000
+++ tests/autopilot/unity8/shell/tests/test_notifications.py	2015-02-17 15:42:02 +0000
@@ -701,3 +701,22 @@
         self.assertThat(get_notification, Eventually(NotEquals(None)))
         self._assert_notification(
             get_notification(), summary, body, False, False, 1.0)
+
+    def test_notification_helper(self):
+        """ use the create notification script to get a notification dialog.
+        Check that the arguments passed to the script match the fields. """
+
+        unity_proxy = self.launch_unity()
+        unlock_unity(unity_proxy)
+
+        summary = 'Helper summary'
+        body = 'Helper body'
+
+        notification = shell.create_ephemeral_notification(summary, body)
+        notification.show()
+
+        notification_data = self.main_window.wait_for_notification()
+
+        self.assertThat(notification_data['summary'],
+                        Eventually(Equals(summary)))
+        self.assertThat(notification_data['body'], Eventually(Equals(body)))