lp:~paulliu/unity8/notification_helper

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity8 at revision 1624

Albert Astals Cid (community): Approve on 2015-02-18

Allan LeSage (community): Approve on 2015-02-18

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2015-02-17

Leo Arias (community): Approve on 2015-02-17

Diff: 63 lines (+37/-0)

3 files modified

tests/autopilot/unity8/shell/__init__.py (+1/-0)
tests/autopilot/unity8/shell/emulators/main_window.py (+17/-0)
tests/autopilot/unity8/shell/tests/test_notifications.py (+19/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1597. By Ying-Chun Liu on 2015-02-17

Fix minor issues.

1596. By Ying-Chun Liu on 2015-02-13

Move to main_window.
Update test_notifications.

1595. By Ying-Chun Liu on 2015-02-11

fix whitespace

1594. By Ying-Chun Liu on 2015-02-10

Add Notification Helper.

1593. By CI Train Bot Account on 2015-02-05

Releasing 8.02+15.04.20150205-0ubuntu1

1592. By Michael Terry on 2015-02-05

Don't accept multiple "Finish" clicks during the last step of the wizard

Doing so can cause password-setting to be left in an inconsistent state.
Here's how that happens:

A) User clicks Finish multiple times, queuing up multiple input events (queued because Finish makes some blocking calls).
B) The first Finish starts, let's say it's called with new password "1111" and type "passcode". The current password is "" with a type of "swipe".
C) The first Finish completes, having set the password correctly to 1111/passcode.
D) The second Finish starts. Also called with "1111/passcode". But it still thinks the current type is "swipe" because it takes a moment for AccountsService to update itself.
E) The second Finish first changes the display mode hint to "passcode"
F) Then the second Finish can't change the password because it's trying to authenticate using "" when the password is actually "1111" now.
G) So the second Finish enters the "error mode cleanup" stage and tries to revert its display mode hint change from step E. But it's reverting to what it thought the previous type was -- "swipe" -- which uses the "passphrase" hint behind the scenes (instead of "passcode")

Some possible solutions to this:
- Cache the password type locally instead of waiting for AccountsService to update (not a bad idea, but would be done in ubuntu-system-settings, not unity8)
- Don't let the user click the Finish button twice. This seems like a no-brainer that should be done anyway. This would also avoid the whole problem.

To reproduce this bug / test this fix, enable the wizard, enter adb, run "sudo passwd -d phablet", reboot, then go through the wizard but just keep spamming that final Finish button. You'll also notice some slow down because it's trying to do all those Finish operations. Fixes: #1414762
Approved by: Albert Astals Cid

1591. By Andrea Cimitan on 2015-02-05

Background needs to be specified to be visible in horizontal cards Fixes: #1411748
Approved by: Albert Astals Cid

1590. By Daniel d'Andrada on 2015-02-05

Don't show() the lockscreen if it's already being shown

As is has the side-effect of hiding the launcher and indicators panel. Fixes: #1393447
Approved by: Albert Astals Cid

1589. By Andrea Cimitan on 2015-02-05

Fix continue button in wifi wizard page, adds qml-module-qtsysteminfo as unity8 dep Fixes: #1363400
Approved by: Albert Astals Cid

1588. By Albert Astals Cid on 2015-02-05

Implement proper updateRanges for horizontal items (i.e. Carousel, Horizontal List)

Saves lots of unneeded card creation, e.g DashContent::test_noDelegateCreationDestructionOnMove number of buttons goes down from 1395 to 773 on my computer Fixes: #1410128
Approved by: Andrea Cimitan, PS Jenkins bot