Code review comment for lp:~patrick-hetu/charms/precise/gunicorn/python-rewrite

Revision history for this message
Mark Mims (mark-mims) wrote :

This looks awesome... glad you took the time to do the rewrite.

One thing, can you please make this sub provide a website http relation? This way it can be related to a load balancer or reverse proxy.

There're a couple of other things that `charm proof gunicorn` is turning up:

    W: Metadata is missing categories.
    W: No icon.svg file.
    W: missing recommended hook start
    W: missing recommended hook stop

I've filed bugs for a couple of them.

    https://bugs.launchpad.net/charms/+source/gunicorn/+bug/1187419
    https://bugs.launchpad.net/charms/+source/gunicorn/+bug/1187421

for start/stop you might want to stub out empty hooks to quiet `charm proof` or not... your call.

No need to get all of this into this MP... just the website-relation-joined if you would please.

Thanks!

review: Needs Fixing

« Back to merge proposal