Juju Charms Collection
openstack-dashboard package

Code review comment for lp:~openstack-charmers/charms/precise/openstack-dashboard/ha-support

  1. Precise Pangolin (12.04)
  2. ha-support
  3. Merge into trunk
Revision history for this message
Nobuto Murata (nobuto) wrote :

Hi, I'm not in the charmers group, but I found:

257 + if [ "$(config-get offline-compression)" != "yes" ]; then
258 + set_or_update COMPRESS_OFFLINE False
259 + apt-get install -y nodejs node-less
260 + else
261 + set_or_update COMPRESS_OFFLINE True
262 + fi

Installing nodejs and node-less should be in "COMPRESS_OFFLINE True" not "COMPRESS_OFFLINE False", shouldn't it?

« Back to merge proposal