Juju Charms Collection
nagios package

Code review comment for lp:~nicopace/charms/trusty/nagios/all-tests

  1. Trusty Tahr (14.04)
  2. all-tests
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

> The first option tests the 'on' option. That means that nagios should provide
> http and https (that's why the first request is without ssl, and the second
> with.

Ah, fair enough. I think we saw a connection error on the plain http: request at one point, so assume that SSL on meant only SSL, but it makes much more sense that it would enable both and that the test should cover that. It's likely that the connection error we saw was actually due to the missing sentry.wait() calls, so I'll go ahead and re-run those tests to see if that resolved the issue.

« Back to merge proposal