Code review comment for lp:~mwhudson/live-build/x-build-linaro

On Mon, 06 Dec 2010 20:42:54 -0000, James Westby <email address hidden> wrote:
> Hi,
>
> The code looks fine to me, and the changes aren't intrusive, so I'm happy with this.
>
> 166 - ${LH_ROOT_COMMAND} debootstrap ${DEBOOTSTRAP_OPTIONS} --download-only "${LH_DISTRIBUTION}" chroot "${LH_MIRROR_BOOTSTRAP}" "${LH_DEBOOTSTRAP_SCRIPT}"
> 167 + ${LH_ROOT_COMMAND} debootstrap ${DEBOOTSTRAP_OPTIONS} --download-only "${LH_DISTRIBUTION}" chroot "${LH_MIRROR_BOOTSTRAP}" ${LH_DEBOOTSTRAP_SCRIPT:+"$LH_DEBOOTSTRAP_SCRIPT"}
>
> That doesn't use $DEBOOTSTRAP, is that intentional?

Yes, qemu-debootstrap doesn't really support --download-only. I guess
this is a bug, but given what it does "qemu-debootstrap --download-only"
doesn't really make a whole lot of sense. I guess I should include this
as a comment in the source :-)

Cheers,
mwh