Merge lp:~mwhudson/lava-scheduler/job-signals into lp:lava-scheduler

[Michael Hudson-Doyle]

We talked about this yesterday and I think it's OK, but I was tired then and tired now and can't really remember :-)

[Zygmunt Krynicki (zyga)]

+1 :-)

review: Approve

[Michael Hudson-Doyle (mwhudson)]

Unfortunately, it turns out to be a bit more complicated: all the queries need to be changed if _status is the name of the field.

I think some approach of saving the initial value in __init__ and firing the signal in save() if it has changed might work better. Will try that later/tomorrow.

Unmerged revisions

126. By Michael Hudson-Doyle on 2012-02-08

add a job_status_changed signal

=== modified file 'lava_scheduler_app/models.py'
--- lava_scheduler_app/models.py	2012-02-08 22:05:30 +0000
+++ lava_scheduler_app/models.py	2012-02-08 23:36:49 +0000
@@ -6,6 +6,8 @@
 
 from linaro_django_xmlrpc.models import AuthToken
 
+from lava_scheduler_app.signals import job_status_changed
+
 class JSONDataError(ValueError):
     """Error raised when JSON is syntactically valid but ill-formed."""
 
@@ -182,11 +184,17 @@
         blank = True,
         editable = False
     )
-    status = models.IntegerField(
+    _status = models.IntegerField(
         choices = STATUS_CHOICES,
         default = SUBMITTED,
         verbose_name = _(u"Status"),
+        db_column = 'status',
     )
+    def _set_status(self, new_status):
+        job_status_changed.send_robust(sender=self, new_status=new_status, old_status=self.status)
+        self._status = new_status
+    status = property(lambda x:x._status, _set_status)
+    del _set_status
     definition = models.TextField(
         editable = False,
     )
 
=== added file 'lava_scheduler_app/signals.py'
--- lava_scheduler_app/signals.py	1970-01-01 00:00:00 +0000
+++ lava_scheduler_app/signals.py	2012-02-08 23:36:49 +0000
@@ -0,0 +1,4 @@
+import django.dispatch
+
+job_status_changed = django.dispatch.Signal(
+    providing_args=["job", "old_status", "new_status"])