Code review comment for lp:~matsubara/charms/trusty/jenkins/jenkins-bundle

Revision history for this message
Cory Johns (johnsca) wrote :

Diogo,

Thank you for this submission. On the whole, this looks good, but I have some inline comments I've made below that need to be addressed. Nothing major, a couple of small lint errors introduced, some questions / comments in the handling of the extension relation, and what looks to be a carry-over of a bug with the password handling in one spot. Again, thanks for this work!

review: Needs Fixing

« Back to merge proposal