Code review comment for lp:~lutostag/charms/trusty/jenkins/jenkins+executor+remote-deb+plugins-move

Revision history for this message
Adam Israel (aisrael) wrote :

Hi Greg,

Thanks for your work on this patch so far! There are a few minor concerns, like proxy access in certain network configurations and payload verification (i.e., checksums) but jenkins isn't currently publishing an sha1 to compare against. Neither of those are immediately solvable, and not enough to hold this back.

+1

review: Approve

« Back to merge proposal