Code review comment for lp:~lutostag/charms/trusty/jenkins/jenkins+executor+remote-deb+plugins-move

Revision history for this message
Ryan Beisner (1chb1n) wrote :

@lutostag

Thanks for you work on this! Everything seems pretty sane to me. The only holdback I have, is that slaves also have executors, and it may be misleading to have a charm config option named 'executors' which is pinned to just the master. Later, someone may want a knob to control the executors on slaves, independent from the master executor setting (ex. I know my test lab has differing quantities of executors on the master than on the slaves).

Perhaps "master-executors" for the charm config option name? That leaves room for slave-executors or something along those lines.

review: Needs Information

« Back to merge proposal