Merge lp:~kaaloo/charms/precise/elasticsearch/trunk into lp:~charmers/charms/precise/elasticsearch/trunk

Proposed by Luis Arias
Status: Merged
Merged at revision: 27
Proposed branch: lp:~kaaloo/charms/precise/elasticsearch/trunk
Merge into: lp:~charmers/charms/precise/elasticsearch/trunk
Diff against target: 53 lines (+6/-6)
3 files modified
config.yaml (+4/-4)
hooks/install (+1/-1)
revision (+1/-1)
To merge this branch: bzr merge lp:~kaaloo/charms/precise/elasticsearch/trunk
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review via email: mp+188226@code.launchpad.net

Description of the change

The default elasticsearch version for this charm was really old so I changed it to 0.90.3 which is the currently compatible version with latest logstash 1.2.1. I changed the download url for elasticsearch because they stopped using github for this a long time ago and now have a download area on elasticsearch.org. I updated the default checksum and also the checksum algorithm to sha1 because elasticsearch.org now provides these.

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Thanks for the update! This looks good to me +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2012-11-06 04:34:30 +0000
+++ config.yaml 2013-09-29 13:37:56 +0000
@@ -1,7 +1,7 @@
1options:1options:
2 version:2 version:
3 type: string3 type: string
4 default: "0.19.10"4 default: "0.90.3"
5 description: |5 description: |
6 This sets the elasticsearch version number that will be used.6 This sets the elasticsearch version number that will be used.
7 If you're going to plug in logstash, make sure versions match.7 If you're going to plug in logstash, make sure versions match.
@@ -36,9 +36,9 @@
36 This sets the s3 bucket name for the elasticsearch s3 gateway.36 This sets the s3 bucket name for the elasticsearch s3 gateway.
37 checksum:37 checksum:
38 type: string38 type: string
39 default: "1e32776a453b7947dc525c4b095b30ce"39 default: "24843192bee3afd19f5a958800e896153dbc3569"
40 description: |40 description: |
41 MD5 checksum of elasticsearch download.41 SHA1 checksum of elasticsearch download.
42 checksumwrapper:42 checksumwrapper:
43 type: string43 type: string
44 default: "450fcee5225cc4837e8b61eb64bcc2d2"44 default: "450fcee5225cc4837e8b61eb64bcc2d2"
@@ -46,7 +46,7 @@
46 MD5 checksum of elasticsearch service wrapper download.46 MD5 checksum of elasticsearch service wrapper download.
47 downloadurl:47 downloadurl:
48 type: string48 type: string
49 default: "https://github.com/downloads/elasticsearch/elasticsearch"49 default: "https://download.elasticsearch.org/elasticsearch/elasticsearch"
50 description: |50 description: |
51 URL to download elasticsearch from.51 URL to download elasticsearch from.
52 zenmasters:52 zenmasters:
5353
=== modified file 'hooks/install'
--- hooks/install 2012-11-11 18:34:00 +0000
+++ hooks/install 2013-09-29 13:37:56 +0000
@@ -22,7 +22,7 @@
22 # Download and checksum22 # Download and checksum
23 juju-log "elasticsearch wrapper binary not found local ... download"23 juju-log "elasticsearch wrapper binary not found local ... download"
24 wget -q -O /tmp/elasticsearch-$VERSION.tar.gz "${DOWNLOADURL}/elasticsearch-$VERSION.tar.gz"24 wget -q -O /tmp/elasticsearch-$VERSION.tar.gz "${DOWNLOADURL}/elasticsearch-$VERSION.tar.gz"
25 if [[ $(md5sum "/tmp/elasticsearch-$VERSION.tar.gz" | cut -d " " -f 1) != ${CHECKSUM} ]]; then25 if [[ $(sha1sum "/tmp/elasticsearch-$VERSION.tar.gz" | cut -d " " -f 1) != ${CHECKSUM} ]]; then
26 juju-log --log-level CRITICAL "Checksum of elasticsearch-$VERSION.tar.gz failed"26 juju-log --log-level CRITICAL "Checksum of elasticsearch-$VERSION.tar.gz failed"
27 exit 127 exit 1
28 fi28 fi
2929
=== modified file 'revision'
--- revision 2012-06-19 09:49:47 +0000
+++ revision 2013-09-29 13:37:56 +0000
@@ -1,1 +1,1 @@
126128

Subscribers

People subscribed via source and target branches

to all changes: