Thanks I like this, I'll approve it pending the answer to the one question
https://codereview.appspot.com/100680044/diff/1/hooks/hooks.py File hooks/hooks.py (right):
https://codereview.appspot.com/100680044/diff/1/hooks/hooks.py#newcode18 hooks/hooks.py:18: def register(): why the containing method? it seems fine to register with hooks on import
https://codereview.appspot.com/100680044/diff/1/hooks/hooks.py#newcode41 hooks/hooks.py:41: 'router-relation-changed')(services.reconfigure_services) The other pattern is more familiar but I think we could get people used to this and it has the advantage of being very concise. :)
https://codereview.appspot.com/100680044/
« Back to merge proposal
Thanks I like this, I'll approve it pending the answer to the one
question
https:/ /codereview. appspot. com/100680044/ diff/1/ hooks/hooks. py
File hooks/hooks.py (right):
https:/ /codereview. appspot. com/100680044/ diff/1/ hooks/hooks. py#newcode18
hooks/hooks.py:18: def register():
why the containing method? it seems fine to register with hooks on
import
https:/ /codereview. appspot. com/100680044/ diff/1/ hooks/hooks. py#newcode41 relation- changed' )(services. reconfigure_ services)
hooks/hooks.py:41:
'router-
The other pattern is more familiar but I think we could get people used
to this and it has the advantage of being very concise. :)
https:/ /codereview. appspot. com/100680044/