Juju Charms Collection
cf-cloud-controller package

Code review comment for lp:~johnsca/charms/trusty/cf-cloud-controller/refactor

  1. Trusty Tahr (14.04)
  2. refactor
  3. Merge into trunk
Revision history for this message
Benjamin Saller (bcsaller) wrote :

On 2014/05/19 19:20:32, cory.johns wrote:
> https://codereview.appspot.com/91450050/diff/20001/hooks/install
> File hooks/install (right):

https://codereview.appspot.com/91450050/diff/20001/hooks/install#newcode60
> hooks/install:60: common.FOG_CONNECTION,
> On 2014/05/19 18:52:05, benjamin.saller wrote:
> > As for config/common naming, I don't mind either as long as we keep
 it
> > consistent.

> The reason we renamed it to common was that it had the shared
db_migrate method
> in it. With the removal of the partial sqlite support, that could be
moved into
> hooks.py and the impetus for naming it common is moot. So perhaps I
will change
> it back to be consistent with the other charms.

Sounds good, thanks

https://codereview.appspot.com/91450050/

« Back to merge proposal