https://codereview.appspot.com/91450050/diff/20001/hooks/install#newcode69
hooks/install:69: common.db_migrate()
I saw you added mysql relation to metadata.yml. It will be really cool
to have opportunity to connect it. Yay! But how and when are you going
create/migrate database for it? Also the question with config template
is still open.
https:/ /codereview. appspot. com/91450050/ diff/20001/ hooks/install
File hooks/install (right):
https:/ /codereview. appspot. com/91450050/ diff/20001/ hooks/install# newcode60 FOG_CONNECTION,
hooks/install:60: common.
I can't get why you called it common and not config, and why we can't
have separate file for all this config options to parse it using
ConfigParser or similar tool.
https:/ /codereview. appspot. com/91450050/ diff/20001/ hooks/install# newcode69
hooks/install:69: common.db_migrate()
I saw you added mysql relation to metadata.yml. It will be really cool
to have opportunity to connect it. Yay! But how and when are you going
create/migrate database for it? Also the question with config template
is still open.
https:/ /codereview. appspot. com/91450050/ diff/20001/ templates/ cloud_controlle r.yml cloud_controlle r.yml (right):
File templates/
https:/ /codereview. appspot. com/91450050/ diff/20001/ templates/ cloud_controlle r.yml#newcode57 cloud_controlle r.yml:57: database: {{db['dsn']}}
templates/
Is it the last version? I'm not 100% sure it will work with changes in
relations. how do you plan to connect mysql relation here?
https:/ /codereview. appspot. com/91450050/